[elasticsearch] Fix host tagging for external clusters. #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbranagan
force-pushed
the
conor/es-external
branch
from
5278ac1 to
df816dc
Compare
LeoCavaille
changed the title
|
Looks good to me, only one thing to add maybe (but it is actually a "bug" coming from my refactoring) is to use |
When using an external Elasticsearch cluster, we should tag the hostname by the node's given hostname in the stats output. Otherwise we end up using only the last node's values because each subsequent gauge metric will stomp on the one before it. The test is updated to make sure the hostname given in the stats (which should be the FQDN) matches what we output at the end. Finally, this change also splits the cluster health metrics into a seperate dict. This has two benefits: (a) it will clean up a lot of debugging logging and extra work for `_process_health_data` and (b) makes it easy to check against just the stats metrics for tests.
LeoCavaille
force-pushed
the
conor/es-external
branch
from
df816dc to
912908c
Compare
|
Took care of the small comment above, merging. |
LeoCavaille
added a commit
that referenced
this pull request
Jan 14, 2015
[elasticsearch] Fix host tagging for external clusters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an external Elasticsearch cluster, we should tag the
hostname by the node's given hostname in the stats output. Otherwise
we end up using only the last node's values because each subsequent
gauge metric will stomp on the one before it.
The test is updated to make sure the hostname given in the stats
(which should be the FQDN) matches what we output at the end.
Finally, this change also splits the cluster health metrics into a
seperate dict. This has two benefits: (a) it will clean up a lot of
debugging logging and extra work for
_process_health_dataand(b) makes it easy to check against just the stats metrics for tests.