is_external should always be cast as a bool

DataDog · Jan 14, 2015 · 912908c · 912908c
1 parent 677417f
commit 912908c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/checks.d/elastic.py b/checks.d/elastic.py
@@ -10,6 +10,7 @@
 
 # project
 from checks import AgentCheck
+from config import _is_affirmative
 from util import headers, Platform
 
 
@@ -141,7 +142,7 @@ def get_instance_config(self, instance):
         if url is None:
             raise Exception("An url must be specified in the instance")
 
-        is_external = instance.get('is_external', False)
+        is_external = _is_affirmative(instance.get('is_external', False))
 
         # Support URLs that have a path in them from the config, for
         # backwards-compatibility.