[postinst] Make dd-agent user and group own /opt/datadog-agent
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of the Agent can then give no permissions at all to other users on the `/opt/datadog-agent` directory (which is the home directory of `dd-agent`), and the Agent can still work fine and not break the users' changes on upgrade. Also, on debian, set the home directory of `dd-agent` to `/opt/datadog-agent` directly on the `adduser` call, for the sake of brevity.
gmmeyer
approved these changes
Oct 27, 2016
|
Please add a big disclaimer in the CHANGELOG. People might not expect this to happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Makes
dd-agentuser and group own/opt/datadog-agent(which is the home directory ofdd-agent)Motivation
Customer request: with this change, sysadmins can give no permissions at all to other users on the
/opt/datadog-agentdirectory (required for PCI compliance), and the Agent can still work fine and not break the sysadmins' changes on upgrade.Testing
Tested the install of a local debian build: from scratch and as an upgrade ; both work fine.
Additional notes
Also, on debian, set the home directory of
dd-agentto/opt/datadog-agentdirectly on theaddusercall, for the sake ofbrevity.