-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inode resolution mechanism for Origin Detection #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdhif
force-pushed
the
CONTINT-1099/wassim.dhif/dogstatsd-inode
branch
6 times, most recently
from
January 16, 2024 17:01
878714e
to
82f01d2
Compare
vickenty
reviewed
Jan 16, 2024
AliDatadog
previously approved these changes
Jan 17, 2024
AliDatadog
reviewed
Jan 17, 2024
AliDatadog
reviewed
Jan 17, 2024
vickenty
reviewed
Jan 17, 2024
wdhif
force-pushed
the
CONTINT-1099/wassim.dhif/dogstatsd-inode
branch
from
January 17, 2024 16:40
f027da4
to
aab46ee
Compare
Signed-off-by: Wassim DHIF <[email protected]>
Co-authored-by: Vickenty Fesunov <[email protected]>
Co-authored-by: Vickenty Fesunov <[email protected]>
Co-authored-by: Vickenty Fesunov <[email protected]>
Co-authored-by: Vickenty Fesunov <[email protected]>
Signed-off-by: Wassim DHIF <[email protected]>
Signed-off-by: Wassim DHIF <[email protected]>
Signed-off-by: Wassim DHIF <[email protected]>
wdhif
force-pushed
the
CONTINT-1099/wassim.dhif/dogstatsd-inode
branch
from
January 17, 2024 16:45
aab46ee
to
63eace9
Compare
vickenty
reviewed
Jan 18, 2024
wdhif
force-pushed
the
CONTINT-1099/wassim.dhif/dogstatsd-inode
branch
from
January 18, 2024 14:25
63eace9
to
97b714b
Compare
vickenty
reviewed
Jan 18, 2024
Signed-off-by: Wassim DHIF <[email protected]>
wdhif
force-pushed
the
CONTINT-1099/wassim.dhif/dogstatsd-inode
branch
from
January 18, 2024 16:13
97b714b
to
46adcf5
Compare
vickenty
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Implements the support of Origin Detection when the container ID is unavailable from inside the container by using the inode resolution mechanic. The original Go implementation is here: DataDog/datadog-go#291
Description of the Change
If we are not able to find the container ID from inside the container, we will send instead the cgroup inode to be able to resolve the container ID on the Agent side.
Alternate Designs
Possible Drawbacks
Verification Process
Use the following deployment on a k8s cluster running
cgroupv2
:You should then be able to find a
dummy.dsd.python.metric
with acontainer_id
tag.Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.