This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
sql: quantize as aliases. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some of them can be unbounded and don't materially change the contents
of the query. here's the direct case:
SELECT pg_try_advisory_lock ( ? ) AS tabcdef1235
clutchski
commented
Feb 6, 2017
| @@ -25,28 +24,16 @@ type QuantizeFunction func(model.Span) model.Span | |||
| func Quantize(span model.Span) model.Span { | |||
| switch span.Type { | |||
| case sqlType: | |||
| fallthrough | |||
| return QuantizeSQL(span) | |||
There was a problem hiding this comment.
explicit is better than implicit
palazzem
approved these changes
Feb 7, 2017
| @@ -25,28 +24,16 @@ type QuantizeFunction func(model.Span) model.Span | |||
| func Quantize(span model.Span) model.Span { | |||
| switch span.Type { | |||
| case sqlType: | |||
| fallthrough | |||
| return QuantizeSQL(span) | |||
quantizer/sql.go
Outdated
| @@ -51,6 +51,8 @@ func (f *ReplaceFilter) Filter(token, lastToken int, buffer []byte) (int, []byte | |||
| return Filtered, []byte("?") | |||
| case Limit: | |||
| return token, buffer | |||
| case As: | |||
| return token, []byte("?") | |||
There was a problem hiding this comment.
happy that is quite easy to extend quantizer rules
quantizer/sql_test.go
Outdated
| @@ -244,6 +244,10 @@ func TestSQLQuantizer(t *testing.T) { | |||
| "SELECT * FROM public.table ( array [ ROW ( array [ 'magic', 'foo',", | |||
| "SELECT * FROM public.table ( array [ ROW ( array [ ?", | |||
| }, | |||
| { | |||
| "SELECT pg_try_advisory_lock (123) AS t46eef3f025cc27feb31ca5a2d668a09a", | |||
| "SELECT pg_try_advisory_lock ( ? ) AS ?", | |||
There was a problem hiding this comment.
For now I think it's ok, we may want (as you've already suggested) to drop all tables/store procedures aliasing. We may keep track of this change for the future.
|
@palazzem we talked about completely dropping all the |
LeoCavaille
approved these changes
Feb 20, 2017
LotharSee
approved these changes
Feb 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some of them can be unbounded and don't materially change the contents
of the query. here's the direct case:
this could also be quantized to
SELECT pg_try_advisory_lock ( ? )but i din't do that.