Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS permission for the parameter DdFetchLogGroupTags #880

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

ssolmonson
Copy link
Contributor

What does this PR do?

Updates the AWS permission in the README for the DdFetchLogGroupTags to logs:ListTagsForResource since AWS has deprecated the logs:ListTagsLogGroup permission.

Motivation

Customer had submitted feedback that this parameter should be updated in the documentation.
https://datadog.zendesk.com/agent/tickets/1977402
https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_ListTagsLogGroup.html
The update to this permission can be found here but the documentation had not been updated

Testing Guidelines

  • Verified the release from Forwarder version 3.115.0 where the change was made
  • Reached out in support-aws-integrations to further confirm this permission should be updated in the documentation as well

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Dec 31, 2024
@maycmlee maycmlee self-assigned this Dec 31, 2024
@ssolmonson ssolmonson merged commit 7d7de6e into master Dec 31, 2024
12 checks passed
@ssolmonson ssolmonson deleted the ssolmonson/update_log_group_tag_action branch December 31, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants