[Logs forwarder] Parse enhanced metrics from Lambda telemetry JSON logs. #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These get emitted instead of regular REPORT logs if log format is set to JSON.
dtcaciuc-ggs
force-pushed
the
json-metrics
branch
from
a51e969 to
b73dc0d
Compare
dtcaciuc-ggs
changed the title
ge0Aja
reviewed
Oct 29, 2024
Comment on lines
262
to
270
| MEMORY_ALLOCATED_RECORD_KEY = "memorySizeMB" | ||
| INIT_DURATION_RECORD_KEY = "initDurationMs" | ||
| BILLED_DURATION_RECORD_KEY = "billedDurationMs" | ||
| RUNTIME_METRICS_BY_RECORD_KEY = { | ||
| # Except INIT_DURATION_RECORD_KEY which is handled separately | ||
| "durationMs": DURATION_METRIC_NAME, | ||
| BILLED_DURATION_RECORD_KEY: BILLED_DURATION_METRIC_NAME, | ||
| "maxMemoryUsedMB": MAX_MEMORY_USED_METRIC_NAME, | ||
| } |
There was a problem hiding this comment.
nit: could you move these to the top of the file.
nit: let's put dureationMs and maxMemeoryUsedMB as keys as well
ge0Aja
reviewed
Oct 29, 2024
Comment on lines
274
to
275
| if not log_message.startswith("{"): | ||
| return [] |
There was a problem hiding this comment.
nit: no need for this here, we can return at the try/except of parsing json fails
ge0Aja
reviewed
Oct 29, 2024
| ) | ||
| ) | ||
|
|
||
| if record["status"] == "timeout": |
There was a problem hiding this comment.
Suggested change
| if record["status"] == "timeout": | |
| if record.get("status") == "timeout": |
ge0Aja
reviewed
Oct 29, 2024
| f"{MEMORY_ALLOCATED_FIELD_NAME}:{record_metrics[MEMORY_ALLOCATED_RECORD_KEY]}" | ||
| ] | ||
|
|
||
| try: |
There was a problem hiding this comment.
to have less try/except patterns
Suggested change
| try: | |
| init_duration = record_metrics.get(INIT_DURATION_RECORD_KEY) | |
| if init_duration: | |
| tags.append("cold_start:true") | |
| metrics.append( | |
| DatadogMetricPoint( | |
| f"{ENHANCED_METRICS_NAMESPACE_PREFIX}.{INIT_DURATION_METRIC_NAME}", | |
| init_duration * METRIC_ADJUSTMENT_FACTORS[INIT_DURATION_METRIC_NAME], | |
| ) | |
| ) | |
| else: | |
| tags.append("cold_start:false") |
There was a problem hiding this comment.
Hm, for some reason, suggestion code doesn't have removed lines I'd expected it to have. I'll apply this change with the rest in one commit.
* Less try/catch * Organize constants * Remove unnecessary defensive JSON check
ge0Aja
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change makes forwarder parse enhanced metrics from Lambda telemetry logs which get emitted instead of regular REPORT ones when JSON format is enabled. For schema, see https://docs.aws.amazon.com/lambda/latest/dg/telemetry-schema-reference.html#platform-report
Motivation
I would like to see same basic enhanced metrics I see when Lambda uses plain text logging when I enable JSON logging option.
Testing Guidelines
tests/run_unit_tests.shLOG_FORMAT=JSONenvar set and confirmed enhanced telemetry is showing upAdditional Notes
cold_starttag is set for REPORT logs but for some reason neither show up in our DD instanceTypes of changes
Check all that apply