Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWSX-678] Restructure files in the lambda forwarder #742

Merged
merged 8 commits into from
Feb 28, 2024
Merged

[AWSX-678] Restructure files in the lambda forwarder #742

merged 8 commits into from
Feb 28, 2024

Conversation

ge0Aja
Copy link
Contributor

@ge0Aja ge0Aja commented Feb 26, 2024

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Feb 26, 2024
@ge0Aja ge0Aja changed the title [AWSX-678] Step1: restructure files in the lambda forwarder [AWSX-678] Restructure files in the lambda forwarder Feb 26, 2024
@ge0Aja ge0Aja force-pushed the georgi/awsx-678 branch 2 times, most recently from c508497 to 301ac27 Compare February 26, 2024 14:02
ge0Aja
ge0Aja commented Feb 26, 2024
View reviewed changes
aws/logs_monitoring/setup.py
@@ -24,4 +24,5 @@
extras_require={
"dev": ["nose2==0.9.1", "flake8==3.7.9", "requests==2.22.0", "boto3==1.10.33"]
},
py_modules=[],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed because of pypa/setuptools#3197 (comment)

@ge0Aja ge0Aja marked this pull request as ready for review February 26, 2024 15:46
@ge0Aja ge0Aja merged commit 743e0e7 into master Feb 28, 2024
13 checks passed
@ge0Aja ge0Aja deleted the georgi/awsx-678 branch February 28, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViBiOh ViBiOh ViBiOh approved these changes

Assignees
No one assigned
Labels
aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ge0Aja @ViBiOh