Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): rename for fixing template capitalization #705

Merged

Conversation

ava-silver
Copy link
Contributor

@ava-silver ava-silver commented Oct 27, 2023

What does this PR do?

un-reverts the capitalization fix

NOTE: this must wait on the UI changes to be merged to merge this, as without those fully rolled out, things will break

Made the change as two operations to keep git history/blame:

rm CreateUIDefinition.json
git mv CreateUiDefinition.json CreateUIDefinition.json

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@ava-silver
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 31, 2023

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

you can cancel this operation by commenting your pull request with /merge -c!

@dd-devflow
Copy link

dd-devflow bot commented Oct 31, 2023

🚨 MergeQueue

gitlab pipeline didn't start by itself and we failed at creating it ... please retry. (type: GitlabError, retryable: false): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 38, startedEventID: 39, identity: 1@gitlab-worker-75769bd77-fdkxq@): POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/datadog-serverless-functions/pipeline: 400 {message: {base: [Missing CI config file]}} (type: ErrorResponse, retryable: true)

If you need support, contact us on slack #ci-interfaces with those details!

@ava-silver ava-silver merged commit a58fdc2 into master Oct 31, 2023
11 of 12 checks passed
@ava-silver ava-silver deleted the ava.silver/finish-arm-template-capitalization-migration branch October 31, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants