Support for using statsd.Client as an otel.MeterProvider
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/master: update comments fix unit tests using global state fix unit tests Send both origin the container-id and the ENTITY_ID Fix cgroup parsing in ECS Fargate (DataDog#305) added dedicated codepath + comment fix cgroupv1 origin detection add description to test make sure we retrieve the cgroup inode when the cid is not found
imle
force-pushed
the
simle/add-otel-support
branch
from
58d8d0d to
9d15e76
Compare
|
I wonder if this will break our compatibility with older versions of Golang. At the moment |
imle
force-pushed
the
simle/add-otel-support
branch
from
9d15e76 to
ed9e51d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to get some comments and guidance on this approach before getting to far into the weeds.
After a number of attempts, I settled on implementing the MeterProvider interface as a passthrough for otel metrics to the
statsd.Client. This keeps much of the pipelineing system from otel out of the way of keeping things lined up with how this library already sends metrics.Outstanding Work:
verify that it is acceptable to send afloat64as aCountervalueit does not appear to be acceptable