Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create install info file #52

Merged
merged 4 commits into from
Jun 4, 2020
Merged

Create install info file #52

merged 4 commits into from
Jun 4, 2020

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 1, 2020

What does this PR do?

Creates install_info file with information about the install method used (overwrites any other existing file).

Additional information

  • The formula version is managed by git tags. I decided to hardcode the version in a variable because: (i) there is no guarantee that the user will clone the repo instead of, e. g., downloading the contents as a ZIP and (ii) there seems to be no way to run commands on the master (which is the one which could access this information anyway).
  • The saltstack version provided by the install_info file is the one on the specific minion where it is being installed.

Describe your test plan

I added tests to the pipeline to check the install_info file is created with the correct information.

@mx-psi mx-psi requested a review from a team as a code owner June 1, 2020 08:15
KSerrania
KSerrania approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few nits

datadog/files/install_info.jinja Outdated Show resolved Hide resolved
test/utils/check_apt_install.py Outdated Show resolved Hide resolved
test/utils/check_yum_install.py Outdated Show resolved Hide resolved
test/utils/check_yum_install.py Outdated Show resolved Hide resolved
test/utils/check_apt_install.py Outdated Show resolved Hide resolved
test/utils/check_apt_install.py Outdated Show resolved Hide resolved
@mx-psi mx-psi merged commit cdee2eb into master Jun 4, 2020
@mx-psi mx-psi deleted the mx-psi/install-info branch June 4, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSerrania KSerrania KSerrania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mx-psi @KSerrania