Remove old check config file if check is installed with Agent 6/7 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the CI is running as there's no I suspect that you tried it manually so it LGTM but maybe I'll let @albertvaka re-review :). |
|
I activated circleci to test it for this PR: #46, but the activation is done for the whole repository, which means it runs even on branches where the |
albertvaka
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove
conf.d/<check>.yamlif a check is enabled and Agent 6/7 is installed, preventing config file duplication.Motivation
If the formula is run with <= 2.1 and then 3.0, then both
conf.d/<check>.yamlandconf.d/<check>.d/conf.yamlare here, and the Agent picks up both config files, duplicating the checks.