-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0 release #41
Merged
3.0 release #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og.yaml (#35) Separates the root pillar object 'datadog' into two sub-objects: - "config", which describes the contents of the datadog.yaml config file that will be installed on the minions, - "install_settings", which contains various customizable parameters for the Agent install, such as the Agent version. With this new structure, any arbitrary key can be put in "config", and will be reflected in the minions' config files. Agent 5 is using a .ini config file, and there's no ini renderer available easily, so we're using the old way with explicitly supported options (except a little cleaner: we're not matching regexes in a file we don't have control of). To comply with what was previously supported on Agent 5 on SaltStack, the api_key option is supported for now.
Removes the pkg_name, service_name, config_folder and config_file options, as they shouldn't be set by the user. Removes the checks_confd option ; instead, uses the Agent confd_path option to get the location where checks configs are located.
Adds a version option for each check configuration, allowing users to choose the check version used. Uses the datadog-agent integration command to get and install the chosen version. Agent 6 only. The check configuration has been moved under the config option of the check. Co-Authored-By: Albert Vaca <[email protected]>
Changes the formula to support the Agent v7 distribution channels (apt & yum repositories). latest will now point to the latest package in the 7 channel. Updates documentation to include v7. Co-Authored-By: Albert Vaca <[email protected]> Co-Authored-By: Olivier Vielpeau <[email protected]>
Fixes the yum repository path for beta installs (Agent 6 betas are in beta/6, Agent 7 betas in beta/7). Fixes the regex which checks if a beta version will be installed (there was a -[0-9]+ too much at the end of the regex). The previous regex would match 7.15.0~beta.1-1 and not 7.15.0~beta.1, which makes the install fail since we add the -1 again during the installation (giving 7.15.0~beta.1-1-1, which is not an existing version).
Agent 7 packages will only be signed using our new GPG key, so we can remove the old one from the repository file if installing Agent 7.
albertvaka
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🔝
Testing nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains all PRs for the 3.0 release:
<check>.d
directory for Agent 6 and 7 ([Agent 6] Put check config in <check>.d directory #39)