[pkg/otlp/model] Fix default for sendCountSum #9273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
added
changelog/no-changelog
[deprecated] team/agent-platform
[deprecated] qa/skip-qa - use other qa/ labels
KSerrania
reviewed
Sep 28, 2021
KSerrania
approved these changes
Sep 28, 2021
mx-psi
added a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Sep 30, 2021
This backports fixes from: - DataDog/datadog-agent@a258ba7, - DataDog/datadog-agent#9266 and - DataDog/datadog-agent#9273.
tigrannajaryan
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2021
…tion (#5270) This backports fixes from: - DataDog/datadog-agent@a258ba7, - DataDog/datadog-agent#9266 and - DataDog/datadog-agent#9273.
zandrewitte
pushed a commit
to StackVista/stackstate-agent
that referenced
this pull request
Nov 17, 2022
* [pkg/otlp/model] Fix default for sendCountSum * Address review comment * Add check for illegal configuration * Fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix default value for
SendCountSumMotivation
WithCountSumMetricis useless otherwise.Describe how to test your changes
End user change is that user does not see the
.sumand.countmetrics. Addingskip-qaand will clarify on the main PR.Checklist
changelog/no-changeloglabel has been applied.need-change/operatorandneed-change/helmlabels has been applied if applicable.team/..label has been applied, if known.Triagemilestone is set.Note: Adding GitHub labels is only possible for contributors with write access.