fix: Allow admission control webhook to be reinvoked if further hooks change things #8351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mikebryant |
ahmed-mez
reviewed
Mar 21, 2022
There was a problem hiding this comment.
Hi @mikebryant
Thanks for the contribution, we'd like to approve it and get it merged - could you please rebase and make the change in here and here + adapt the unit tests?
Thank you!
9 tasks
|
@mikebryant I opened this PR #11440 for the same purpose. Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow the hooks to be invoked again if another hook makes changes to the same object
Motivation
I wanted to use a different hook to set the datadog labels
Describe how to test your changes
Create a Kyverno policy as in #8350 and make sure it reliably creates the
DD_SERVICEenvironment variable