Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-4412] Upgrade k8s dependencies #30061

Merged
merged 22 commits into from
Nov 7, 2024
Merged

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Oct 11, 2024

What does this PR do?

  1. Update kubernetes and related dependencies.
  2. Update ddflareextension component
    Previously, in order to store/get the redacted config, we needed to unmarshal the confmap.Conf passed to NotifyConfig into a otelcol.Config in order to take advantage of the redaction of configopaque.String.
    Since the changes in the following PR: [otelcol] Obtain the Collector's effective configuration from otelcol.Config open-telemetry/opentelemetry-collector#10139, the confmap.Conf passed to NotifyConfig is redacted already as it is built from a otelcol.Config (see here) so we can remove all unmarshalling logic and store the confmap.Conf directly.

Motivation

Describe how to test/QA your changes

Launch the converged agent without any extensions. Then trigger a flare.

Ensure that:

  • The provided and enhanced config are in the flare
  • The provided and enhanced config in the flare have sensitive fields redacted with '[REDACTED]'.
  • The extensions data is in the flare

Possible Drawbacks / Trade-offs

Additional Notes

Supersedes #28585.

go.mod Outdated
github.com/DataDog/datadog-go/v5 v5.5.0
github.com/DataDog/datadog-operator v1.8.0-rc.1
github.com/DataDog/datadog-operator v0.7.1-0.20241010110733-dbbe6d120655
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the commit of DataDog/datadog-operator#1445.

To be updated as soon as this PR is merged.

go.mod Outdated
@@ -165,7 +167,7 @@ require (
github.com/DataDog/opentelemetry-mapping-go/pkg/quantile v0.20.0
github.com/DataDog/sketches-go v1.4.6
github.com/DataDog/viper v1.13.5
github.com/DataDog/watermarkpodautoscaler v0.6.1
github.com/DataDog/watermarkpodautoscaler v0.5.3-0.20241011111846-034635582ee1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the commit of DataDog/watermarkpodautoscaler#221.

To be updated as soon as this PR is merged.

Copy link

cit-pr-commenter bot commented Oct 11, 2024

Go Package Import Differences

This comment was omitted because it was over 65,536 characters. Please check the Gitlab Job logs to see its output.

@L3n41c L3n41c force-pushed the lenaic/CONTINT-4412 branch from 1e31c20 to 58f9908 Compare October 11, 2024 16:14
Copy link

cit-pr-commenter bot commented Oct 11, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 12a86640-7bdb-4433-9849-15b4985024f8

Baseline: e830ee5
Comparison: 4479926
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +4.91 [+1.29, +8.53] 1 Logs
idle_all_features memory utilization +2.60 [+2.47, +2.73] 1 Logs bounds checks dashboard
idle memory utilization +1.41 [+1.36, +1.47] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +1.34 [+1.22, +1.47] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +1.22 [+0.50, +1.95] 1 Logs
quality_gate_idle memory utilization +1.21 [+1.16, +1.27] 1 Logs bounds checks dashboard
file_tree memory utilization +1.18 [+1.05, +1.31] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.58 [+0.52, +0.63] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.21 [-0.27, +0.70] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.07 [-0.12, +0.26] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.09, +0.08] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.27, +0.26] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.42, +0.41] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.28, +0.22] 1 Logs
basic_py_check % cpu utilization -0.62 [-4.49, +3.26] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle memory_usage 5/10 bounds checks dashboard
idle memory_usage 7/10 bounds checks dashboard
idle_all_features memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

go.mod Outdated

// Prevent a false-positive detection by the Google and Ikarus security vendors on VirusTotal
exclude go.opentelemetry.io/proto/otlp v1.1.0

replace github.com/google/gopacket v1.1.19 => github.com/DataDog/gopacket v0.0.0-20240626205202-4ac4cee31f14

// Remove once https://github.com/kubernetes-sigs/custom-metrics-apiserver/pull/184 is merged
replace sigs.k8s.io/custom-metrics-apiserver v1.30.0 => github.com/L3n41c/custom-metrics-apiserver v0.0.0-20241014100211-ccded82d0da2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the commit of kubernetes-sigs/custom-metrics-apiserver#184.

To be updated as soon as this PR is merged.

@L3n41c L3n41c force-pushed the lenaic/CONTINT-4412 branch 6 times, most recently from 38710a7 to 7c22c88 Compare October 18, 2024 15:31
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 18, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48445688 --os-family=ubuntu

Note: This applies to commit 4479926

@L3n41c L3n41c force-pushed the lenaic/CONTINT-4412 branch 2 times, most recently from 37696fe to b686d5f Compare October 19, 2024 12:17
@L3n41c L3n41c force-pushed the lenaic/CONTINT-4412 branch from b686d5f to 58f6136 Compare October 19, 2024 18:14
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 20, 2024

Gitlab CI Configuration Changes

Modified Jobs

docker_image_build_otel
  docker_image_build_otel:
    before_script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache.tar.xz
    - mkdir -p /tmp/otel-ci
    - cp comp/otelcol/collector-contrib/impl/manifest.yaml /tmp/otel-ci/
    - cp Dockerfiles/agent-ot/Dockerfile.agent-otel /tmp/otel-ci/
    - cp test/integration/docker/otel_agent_build_tests.py /tmp/otel-ci/
    - wget https://github.com/mikefarah/yq/releases/download/3.4.1/yq_linux_amd64 -O
      /usr/bin/yq && chmod +x /usr/bin/yq
    - export OTELCOL_VERSION=v$(/usr/bin/yq r /tmp/otel-ci/manifest.yaml dist.otelcol_version)
    - yq w -i /tmp/otel-ci/manifest.yaml "receivers[+] gomod" "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8sobjectsreceiver
      ${OTELCOL_VERSION}"
    - yq w -i /tmp/otel-ci/manifest.yaml "processors[+] gomod" "github.com/open-telemetry/opentelemetry-collector-contrib/processor/metricstransformprocessor
      ${OTELCOL_VERSION}"
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
    needs:
    - go_deps
    - integration_tests_otel
    rules:
    - if: $CI_PIPELINE_SOURCE =~ /^schedule.*$/
      when: never
    - if: $CI_COMMIT_TAG
      when: never
    - if: $CI_COMMIT_MESSAGE =~ /.*\[skip cancel\].*/
      when: never
    - if: $CI_COMMIT_REF_NAME =~ /.*-skip-cancel$/
      when: never
    - when: always
    script:
+   - docker build --build-arg AGENT_BRANCH=$CI_COMMIT_BRANCH --tag agent-byoc:latest
-   - docker build -t agent-byoc:latest -f /tmp/otel-ci/Dockerfile.agent-otel /tmp/otel-ci
?   - ---------------------------------
+     -f /tmp/otel-ci/Dockerfile.agent-otel /tmp/otel-ci
    - OT_AGENT_IMAGE_NAME=agent-byoc OT_AGENT_TAG=latest python3 /tmp/otel-ci/otel_agent_build_tests.py
    stage: integration_test
    tags:
    - runner:docker

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

@L3n41c L3n41c force-pushed the lenaic/CONTINT-4412 branch 4 times, most recently from dd1e9c5 to 2c7fa17 Compare October 20, 2024 10:57
@L3n41c L3n41c force-pushed the lenaic/CONTINT-4412 branch 2 times, most recently from f70036b to 5b37b98 Compare October 20, 2024 11:09
Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for fixing my integration test
edit @liustanley if you have time today I'd love to look over the e2e tests with you to get a better understanding why they are failing before this gets merged in

@L3n41c
Copy link
Member Author

L3n41c commented Oct 31, 2024

Some performance issues in kubernetes_state_core check will need to be addressed before this PR can be merged:
dashboard profiles

@L3n41c L3n41c force-pushed the lenaic/CONTINT-4412 branch from 235b2e2 to 8f59c4a Compare November 5, 2024 14:47
@L3n41c
Copy link
Member Author

L3n41c commented Nov 6, 2024

Performance issue is now fixed: dashboard

@L3n41c L3n41c modified the milestones: 7.60.0, 7.61.0 Nov 7, 2024
@L3n41c L3n41c added the team/opentelemetry OpenTelemetry team label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

⚠️🚨 Warning, this pull request increases the binary size of serverless extension by 789472 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 7ms.

Debug info

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

These dependencies were added to the serverless extension by this pull request:

go.opentelemetry.io/collector/pdata/pprofile
go.opentelemetry.io/contrib/config
go.opentelemetry.io/collector/pdata/pcommon

View dependency graphs for each added dependency in the artifacts section of the github action.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between a2867c0 and aef9209.

tl;dr

Use these benchmarks as an insight tool during development.

  1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

  2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats
goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            85.00µ ± 4%   83.03µ ± 4%       ~ (p=0.315 n=10)
api-gateway-kong-appsec.json                       64.54µ ± 1%   65.09µ ± 8%       ~ (p=0.055 n=10)
api-gateway-kong.json                              63.14µ ± 1%   63.82µ ± 1%       ~ (p=0.052 n=10)
api-gateway-non-proxy-async.json                  100.41µ ± 3%   99.67µ ± 1%       ~ (p=0.063 n=10)
api-gateway-non-proxy.json                         100.8µ ± 1%   100.2µ ± 1%       ~ (p=0.172 n=10)
api-gateway-websocket-connect.json                 67.11µ ± 1%   66.88µ ± 1%       ~ (p=0.280 n=10)
api-gateway-websocket-default.json                 60.04µ ± 1%   60.98µ ± 1%  +1.56% (p=0.001 n=10)
api-gateway-websocket-disconnect.json              60.10µ ± 1%   61.09µ ± 1%  +1.65% (p=0.000 n=10)
api-gateway.json                                   111.5µ ± 1%   111.8µ ± 1%       ~ (p=0.684 n=10)
application-load-balancer.json                     61.23µ ± 2%   61.88µ ± 1%       ~ (p=0.105 n=10)
cloudfront.json                                    45.93µ ± 2%   45.64µ ± 1%  -0.63% (p=0.043 n=10)
cloudwatch-events.json                             36.92µ ± 2%   36.92µ ± 1%       ~ (p=0.912 n=10)
cloudwatch-logs.json                               65.45µ ± 2%   64.35µ ± 1%       ~ (p=0.063 n=10)
custom.json                                        29.96µ ± 1%   30.15µ ± 2%       ~ (p=0.436 n=10)
dynamodb.json                                      92.47µ ± 1%   92.10µ ± 1%       ~ (p=0.353 n=10)
empty.json                                         28.35µ ± 1%   28.78µ ± 1%  +1.51% (p=0.009 n=10)
eventbridge-custom.json                            46.36µ ± 1%   46.99µ ± 3%  +1.36% (p=0.043 n=10)
eventbridge-no-bus.json                            45.74µ ± 1%   45.97µ ± 2%       ~ (p=0.436 n=10)
eventbridge-no-timestamp.json                      46.03µ ± 3%   46.29µ ± 1%       ~ (p=0.159 n=10)
eventbridgesns.json                                61.98µ ± 1%   63.34µ ± 2%  +2.20% (p=0.000 n=10)
eventbridgesqs.json                                70.49µ ± 1%   70.97µ ± 1%       ~ (p=0.247 n=10)
http-api.json                                      70.78µ ± 2%   70.83µ ± 2%       ~ (p=0.631 n=10)
kinesis-batch.json                                 71.41µ ± 1%   69.26µ ± 2%  -3.02% (p=0.000 n=10)
kinesis.json                                       54.18µ ± 1%   53.49µ ± 1%       ~ (p=0.063 n=10)
s3.json                                            59.90µ ± 2%   58.94µ ± 1%  -1.59% (p=0.023 n=10)
sns-batch.json                                     91.97µ ± 2%   90.32µ ± 1%       ~ (p=0.123 n=10)
sns.json                                           67.52µ ± 1%   67.59µ ± 1%       ~ (p=0.631 n=10)
snssqs.json                                        115.3µ ± 2%   117.5µ ± 1%  +1.93% (p=0.029 n=10)
snssqs_no_dd_context.json                          105.2µ ± 3%   105.4µ ± 2%       ~ (p=0.353 n=10)
sqs-aws-header.json                                59.74µ ± 2%   59.37µ ± 2%       ~ (p=0.481 n=10)
sqs-batch.json                                     96.16µ ± 3%   95.80µ ± 2%       ~ (p=0.529 n=10)
sqs.json                                           73.37µ ± 1%   73.39µ ± 2%       ~ (p=0.912 n=10)
sqs_no_dd_context.json                             68.02µ ± 1%   68.11µ ± 4%       ~ (p=0.631 n=10)
stepfunction.json                                  47.00µ ± 7%   46.07µ ± 2%  -1.97% (p=0.043 n=10)
geomean                                            64.63µ        64.61µ       -0.03%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.27Ki ± 0%   37.27Ki ± 0%       ~ (p=0.838 n=10)
api-gateway-kong-appsec.json                      26.92Ki ± 0%   26.94Ki ± 0%       ~ (p=0.382 n=10)
api-gateway-kong.json                             24.42Ki ± 0%   24.43Ki ± 0%       ~ (p=0.540 n=10)
api-gateway-non-proxy-async.json                  48.07Ki ± 0%   48.07Ki ± 0%       ~ (p=0.447 n=10)
api-gateway-non-proxy.json                        47.30Ki ± 0%   47.29Ki ± 0%       ~ (p=0.247 n=10)
api-gateway-websocket-connect.json                25.49Ki ± 0%   25.50Ki ± 0%       ~ (p=0.342 n=10)
api-gateway-websocket-default.json                21.39Ki ± 0%   21.41Ki ± 0%  +0.09% (p=0.002 n=10)
api-gateway-websocket-disconnect.json             21.17Ki ± 0%   21.18Ki ± 0%  +0.09% (p=0.004 n=10)
api-gateway.json                                  49.59Ki ± 0%   49.58Ki ± 0%       ~ (p=0.353 n=10)
application-load-balancer.json                    22.36Ki ± 0%   22.37Ki ± 0%       ~ (p=0.270 n=10)
cloudfront.json                                   17.65Ki ± 0%   17.65Ki ± 0%       ~ (p=0.868 n=10)
cloudwatch-events.json                            11.69Ki ± 0%   11.70Ki ± 0%       ~ (p=0.698 n=10)
cloudwatch-logs.json                              53.37Ki ± 0%   53.38Ki ± 0%       ~ (p=0.305 n=10)
custom.json                                       9.716Ki ± 0%   9.723Ki ± 0%       ~ (p=0.614 n=10)
dynamodb.json                                     40.77Ki ± 0%   40.77Ki ± 0%       ~ (p=0.897 n=10)
empty.json                                        9.286Ki ± 0%   9.289Ki ± 0%       ~ (p=0.271 n=10)
eventbridge-custom.json                           15.02Ki ± 0%   15.02Ki ± 0%       ~ (p=0.541 n=10)
eventbridge-no-bus.json                           14.00Ki ± 0%   14.01Ki ± 0%       ~ (p=0.085 n=10)
eventbridge-no-timestamp.json                     14.02Ki ± 0%   14.04Ki ± 0%       ~ (p=0.288 n=10)
eventbridgesns.json                               20.93Ki ± 0%   20.91Ki ± 0%       ~ (p=0.325 n=10)
eventbridgesqs.json                               25.14Ki ± 0%   25.15Ki ± 0%       ~ (p=0.529 n=10)
http-api.json                                     23.89Ki ± 0%   23.88Ki ± 0%       ~ (p=0.542 n=10)
kinesis-batch.json                                27.11Ki ± 0%   27.10Ki ± 0%       ~ (p=0.404 n=10)
kinesis.json                                      17.89Ki ± 0%   17.87Ki ± 1%       ~ (p=0.343 n=10)
s3.json                                           20.44Ki ± 0%   20.44Ki ± 0%       ~ (p=0.928 n=10)
sns-batch.json                                    39.92Ki ± 0%   39.93Ki ± 0%       ~ (p=0.698 n=10)
sns.json                                          25.11Ki ± 0%   25.17Ki ± 0%       ~ (p=0.247 n=10)
snssqs.json                                       53.66Ki ± 0%   53.74Ki ± 0%       ~ (p=0.123 n=10)
snssqs_no_dd_context.json                         47.42Ki ± 1%   47.47Ki ± 0%       ~ (p=0.739 n=10)
sqs-aws-header.json                               19.48Ki ± 1%   19.51Ki ± 0%       ~ (p=0.592 n=10)
sqs-batch.json                                    42.33Ki ± 1%   42.24Ki ± 1%       ~ (p=0.218 n=10)
sqs.json                                          26.28Ki ± 0%   26.26Ki ± 0%       ~ (p=0.912 n=10)
sqs_no_dd_context.json                            21.89Ki ± 1%   21.89Ki ± 1%       ~ (p=0.971 n=10)
stepfunction.json                                 14.26Ki ± 2%   14.24Ki ± 1%       ~ (p=0.739 n=10)
geomean                                           24.55Ki        24.56Ki       +0.02%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             629.0 ± 0%   629.5 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    725.0 ± 0%   725.5 ± 0%       ~ (p=0.350 n=10)
api-gateway-non-proxy.json                          716.0 ± 0%   716.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-connect.json                  453.0 ± 0%   453.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-default.json                  379.0 ± 0%   379.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-disconnect.json               369.0 ± 0%   370.0 ± 0%       ~ (p=0.170 n=10)
api-gateway.json                                    791.0 ± 0%   790.0 ± 0%       ~ (p=0.656 n=10)
application-load-balancer.json                      352.0 ± 0%   352.0 ± 0%       ~ (p=1.000 n=10)
cloudfront.json                                     284.0 ± 0%   284.0 ± 0%       ~ (p=1.000 n=10)
cloudwatch-events.json                              220.0 ± 0%   220.0 ± 0%       ~ (p=0.474 n=10)
cloudwatch-logs.json                                215.0 ± 0%   216.0 ± 0%       ~ (p=0.179 n=10)
custom.json                                         168.0 ± 1%   168.0 ± 0%       ~ (p=1.000 n=10)
dynamodb.json                                       589.0 ± 0%   589.0 ± 0%       ~ (p=1.000 n=10)
empty.json                                          159.0 ± 1%   159.5 ± 0%       ~ (p=1.000 n=10)
eventbridge-custom.json                             266.0 ± 0%   266.0 ± 0%       ~ (p=1.000 n=10)
eventbridge-no-bus.json                             257.0 ± 0%   258.0 ± 0%       ~ (p=0.370 n=10)
eventbridge-no-timestamp.json                       258.0 ± 0%   258.0 ± 0%       ~ (p=0.737 n=10)
eventbridgesns.json                                 326.0 ± 0%   325.0 ± 0%       ~ (p=0.252 n=10)
eventbridgesqs.json                                 367.0 ± 0%   367.0 ± 1%       ~ (p=0.545 n=10)
http-api.json                                       434.0 ± 0%   434.0 ± 0%       ~ (p=0.760 n=10)
kinesis-batch.json                                  392.0 ± 0%   392.0 ± 0%       ~ (p=0.450 n=10)
kinesis.json                                        286.0 ± 0%   286.0 ± 1%       ~ (p=0.456 n=10)
s3.json                                             359.0 ± 0%   359.0 ± 0%       ~ (p=0.969 n=10)
sns-batch.json                                      478.5 ± 1%   478.5 ± 0%       ~ (p=0.793 n=10)
sns.json                                            345.5 ± 0%   347.0 ± 1%       ~ (p=0.181 n=10)
snssqs.json                                         475.5 ± 1%   476.5 ± 1%       ~ (p=0.166 n=10)
snssqs_no_dd_context.json                           435.0 ± 1%   435.5 ± 1%       ~ (p=0.870 n=10)
sqs-aws-header.json                                 287.0 ± 1%   287.0 ± 0%       ~ (p=0.687 n=10)
sqs-batch.json                                      517.0 ± 1%   515.5 ± 1%       ~ (p=0.291 n=10)
sqs.json                                            364.5 ± 1%   364.5 ± 0%       ~ (p=0.888 n=10)
sqs_no_dd_context.json                              349.5 ± 0%   350.0 ± 1%       ~ (p=0.781 n=10)
stepfunction.json                                   237.5 ± 2%   237.0 ± 1%       ~ (p=0.783 n=10)
geomean                                             366.9        367.1       +0.05%
¹ all samples are equal

Comment on lines +15 to +19
# TODO: https://datadoghq.atlassian.net/browse/OTEL-2192
# To be removed once https://github.com/DataDog/datadog-agent/pull/30669 is merged.
test/new-e2e/tests/otel/otlp-ingest:
- TestOTLPIngest
- TestOTLPIngestSampling/TestSampling
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@pgimalac pgimalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR significantly increases agent package size (~50MB), and in particular just k8s.io/client-go goes from 5MB to 12MB in binary size.
This is known, it was deployed and didn't show significant regression, and it will be worked on later, so approving !

@L3n41c
Copy link
Member Author

L3n41c commented Nov 7, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 7, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-07 14:58:39 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit c86d1e0 into main Nov 7, 2024
387 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lenaic/CONTINT-4412 branch November 7, 2024 15:26
@L3n41c L3n41c added the qa/done QA done before merge and regressions are covered by tests label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/containers team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.