Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oracle] Fix empty lock payloads #27015

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

nenadnoveljic
Copy link
Contributor

What does this PR do?

Fixes empty lock payloads.

Motivation

dbm-metrics-processor was sending empty series to metrics intake. Meanwhile, a workaround was implemented on dbm-metrics-processor but the agent shouldn't be sending empty payloads.

Additional Notes

No changelog, since the bug wasn't customer facing.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@nenadnoveljic nenadnoveljic added changelog/no-changelog team/database-monitoring qa/done QA done before merge and regressions are covered by tests labels Jun 24, 2024
@nenadnoveljic nenadnoveljic added this to the 7.56.0 milestone Jun 24, 2024
@nenadnoveljic nenadnoveljic self-assigned this Jun 24, 2024
@nenadnoveljic nenadnoveljic requested a review from a team as a code owner June 24, 2024 15:43
@pr-commenter
Copy link

pr-commenter bot commented Jun 24, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=37435912 --os-family=ubuntu

Note: This applies to commit c4a7dfe

@pr-commenter
Copy link

pr-commenter bot commented Jun 24, 2024

Regression Detector

Regression Detector Results

Run ID: 3f3ace83-d33f-492c-aee8-dd38178dfb0b Metrics dashboard Target profiles

Baseline: 6a6c459
Comparison: c4a7dfe

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
otel_to_otel_logs ingress throughput +1.86 [+1.04, +2.67] Logs
pycheck_1000_100byte_tags % cpu utilization +1.29 [-3.64, +6.23] Logs
basic_py_check % cpu utilization +1.16 [-1.63, +3.95] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.62 [-0.28, +1.51] Logs
file_tree memory utilization +0.55 [+0.44, +0.67] Logs
tcp_syslog_to_blackhole ingress throughput +0.16 [-12.86, +13.17] Logs
idle memory utilization +0.05 [+0.01, +0.09] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@nenadnoveljic
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 25, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit fd2ef75 into main Jun 25, 2024
217 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nenadnoveljic/oracle-empty-metrics-series branch June 25, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/database-monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants