-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warn log for OTel logs agent connectivity check #26626
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=36460065 --os-family=ubuntu Note: This applies to commit 0e6e9a5 |
Regression DetectorRegression Detector ResultsRun ID: f3261861-f082-4f5c-a214-62aee08048e4 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +3.65 | [-17.68, +24.98] |
➖ | file_tree | memory utilization | +0.91 | [+0.81, +1.00] |
➖ | basic_py_check | % cpu utilization | +0.28 | [-2.59, +3.16] |
➖ | idle | memory utilization | +0.24 | [+0.20, +0.28] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.19, +0.22] |
➖ | trace_agent_msgpack | ingress throughput | +0.01 | [+0.01, +0.02] |
➖ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.01] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.02 | [-0.05, +0.01] |
➖ | otel_to_otel_logs | ingress throughput | -0.15 | [-0.53, +0.22] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.52 | [-5.37, +4.32] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.69 | [-4.69, +1.32] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Add default config option to always use http for logs agent exporter. Fixes bug where logs agent exporter was falling back to using tcp, causing collector shut down. Also opened a PR in datadog-agent for adding a warn log when the logs agent connectivity check fails: DataDog/datadog-agent#26626 **Link to tracking Issue:** <Issue number if applicable> Fixes #33195 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
What does this PR do?
Adds a warn log when the connectivity check fails for the OTel logs agent. This will appear as the following in the collector:
Motivation
With this change, we plan to use logs_config.force_use_http in the logs agent default config which should solve this upstream issue: open-telemetry/opentelemetry-collector-contrib#33195
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes