-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dca] Do not load language detection patcher if disabled #24116
[dca] Do not load language detection patcher if disabled #24116
Conversation
[Fast Unit Tests Report] On pipeline 30847096 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=30847096 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: b05b9c70-81e5-4296-9cb9-201c5e78c66d Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
❌ | file_to_blackhole | % cpu utilization | +54.06 | [+47.21, +60.92] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
❌ | file_to_blackhole | % cpu utilization | +54.06 | [+47.21, +60.92] |
➖ | file_tree | memory utilization | +2.08 | [+1.96, +2.21] |
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.55 | [+1.46, +1.64] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.30 | [-1.61, +4.21] |
➖ | idle | memory utilization | +0.98 | [+0.91, +1.05] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.50 | [+0.44, +0.56] |
➖ | otel_to_otel_logs | ingress throughput | +0.06 | [-0.38, +0.51] |
➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.03] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.04, +0.04] |
➖ | trace_agent_msgpack | ingress throughput | -0.01 | [-0.01, -0.00] |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.22, +0.19] |
➖ | process_agent_real_time_mode | memory utilization | -0.50 | [-0.58, -0.43] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.21 | [-6.05, +3.63] |
➖ | process_agent_standard_check | memory utilization | -1.71 | [-1.78, -1.63] |
➖ | basic_py_check | % cpu utilization | -1.84 | [-4.21, +0.52] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 29m) Use |
What does this PR do?
This PR does not load the language detection patcher in the cluster agent if
language_detection.enabled
is set to falseMotivation
Follow-up to #23621, the middle point in the QA section was not working as expected
Additional Notes
I have tested this locally and confirmed that the log line no longer exists when
language_detection.enabled
is set to false, and does show up whenlanguage_detection.enabled
is set to truePossible Drawbacks / Trade-offs
Describe how to test/QA your changes
Same as #23621. Specifically:
Ensure that:
... as the other points in PR have been validated