Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin oscrypto to a git reference to get bugfix #19899

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Oct 3, 2023

What does this PR do?

Pins oscrypto, a snowflake-connector-python dependency, to a version on github which is still unreleased.

Motivation

Get fix for wbond/oscrypto#75, which hasn't been released yet and which breaks the snowflake integration when shipped with OpenSSL version 3.0.11 (and any version with double digits on any version segment).

Additional Notes

Testing this patch manually, agent status shows the integration to be working:

    snowflake (5.0.0)
    -----------------
      Instance ID: snowflake:404312cee7262141 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/snowflake.d/snowflake.yaml
      Total Runs: 1
      Metric Samples: Last Run: 2, Total: 2
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 1
      Average Execution Time : 28.758s
      Last Execution Date : 2023-10-03 14:01:12 UTC (1696341672000)
      Last Successful Execution Date : 2023-10-03 14:01:12 UTC (1696341672000)
      metadata:
        version.major: 7
        version.minor: 34
        version.patch: 1
        version.raw: 7.34.1
        version.scheme: semver

Possible Drawbacks / Trade-offs

We should keep an eye on future oscrypto releases to remove this pin.

Describe how to test/QA your changes

Run the integration

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@alopezz alopezz marked this pull request as ready for review October 3, 2023 14:19
@alopezz alopezz requested a review from a team as a code owner October 3, 2023 14:19
@pr-commenter
Copy link

pr-commenter bot commented Oct 3, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: ecd41ced-008d-49d8-afa5-70d66ea98d45
Baseline: 5efe6c8
Comparison: 1f7284e
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
tcp_syslog_to_blackhole ingress throughput +0.93 [+0.78, +1.08] 100.00%
otel_to_otel_logs ingress throughput +0.15 [-1.44, +1.73] 12.14%
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.06, +0.06] 3.89%
trace_agent_msgpack ingress throughput +0.00 [-0.11, +0.11] 1.30%
uds_dogstatsd_to_api_nodist_nomulti_100MiB ingress throughput +0.00 [-0.13, +0.13] 1.00%
uds_dogstatsd_to_api_nodist_100MiB ingress throughput -0.00 [-0.13, +0.13] 0.46%
trace_agent_json ingress throughput -0.02 [-0.14, +0.11] 17.57%
uds_dogstatsd_to_api_nodist_200MiB ingress throughput -0.18 [-0.29, -0.07] 99.40%
uds_dogstatsd_to_api_nodist_nomulti_200MiB ingress throughput -0.43 [-0.54, -0.32] 100.00%
uds_dogstatsd_to_api ingress throughput -0.46 [-2.63, +1.71] 27.05%
file_to_blackhole egress throughput -0.48 [-1.90, +0.94] 42.37%
file_tree egress throughput -5.86 [-8.08, -3.65] 100.00%

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually write dedicated definitions but approving since the fix should be released soon

@kacper-murzyn kacper-murzyn modified the milestones: Triage, 7.49.0 Oct 4, 2023
@alopezz alopezz merged commit 80cc73d into main Oct 4, 2023
@alopezz alopezz deleted the alopez/omnibus/pin-oscrypto branch October 4, 2023 11:21
vivek-datadog pushed a commit that referenced this pull request Oct 4, 2023
* Pin oscrypto to a git reference to get bugfix

* Use double quotes to be windows-compatible
alopezz added a commit that referenced this pull request Oct 4, 2023
* Pin oscrypto to a git reference to get bugfix

* Use double quotes to be windows-compatible
vivek-datadog pushed a commit that referenced this pull request Oct 4, 2023
* Pin oscrypto to a git reference to get bugfix

* Use double quotes to be windows-compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants