Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ksmcore] Remap unknown to warning for 'node.ready' service check #10549

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

kaitlavs
Copy link
Contributor

What does this PR do?

Remaps the value of the KSMCore node.ready service check from 'unknown' to 'warning' when a node enters an unknown state.

Motivation

Additional Notes

Related to the legacy check PR: DataDog/integrations-core#11132

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

It is difficult to replicate the unknown state of a node, but it can be tested on a large cluster, which is more likely to have a node in this state

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • The appropriate team/.. label has been applied, if known.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@bits-bot
Copy link
Collaborator

bits-bot commented Jan 14, 2022

CLA assistant check
All committers have signed the CLA.

@kaitlavs kaitlavs requested a review from a team as a code owner January 27, 2022 17:47
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@kaitlavs kaitlavs merged commit 7f09e26 into main Jan 27, 2022
@kaitlavs kaitlavs deleted the kaitlavs-ksm-core branch January 27, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants