Skip to content

Commit

Permalink
Rotate package signing keys for DEB and RPM packages (#11489)
Browse files Browse the repository at this point in the history
  • Loading branch information
Slavek Kabrda authored Mar 30, 2022
1 parent d7e2c44 commit 47f71b3
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 5 deletions.
11 changes: 6 additions & 5 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,14 @@ variables:
DOCKER_X64_BUILDER: v2718644-9ce6565-18.09.6-py3
NIKOS_INSTALL_DIR: /opt/datadog-agent/embedded/nikos
NIKOS_EMBEDDED_PATH: /opt/datadog-agent/embedded/nikos/embedded
DEB_GPG_KEY_ID: 8387EEAF
DEB_GPG_KEY_NAME: "Datadog, Inc <[email protected]>"
DEB_GPG_KEY_ID: ad9589b7
DEB_GPG_KEY_NAME: "Datadog, Inc. Master key"
DEB_GPG_KEY_SSM_NAME: ci.datadog-agent.deb_signing_private_key_${DEB_GPG_KEY_ID}
DEB_SIGNING_PASSPHRASE_SSM_NAME: ci.datadog-agent.deb_signing_key_passphrase_${DEB_GPG_KEY_ID}
RPM_GPG_KEY_ID: e09422b3
RPM_GPG_KEY_SSM_NAME: ci.datadog-agent.rpm_signing_private_key_e09422b3
RPM_SIGNING_PASSPHRASE_SSM_NAME: ci.datadog-agent.rpm_signing_key_passphrase_e09422b3
RPM_GPG_KEY_ID: fd4bf915
RPM_GPG_KEY_NAME: "Datadog, Inc. RPM key"
RPM_GPG_KEY_SSM_NAME: ci.datadog-agent.rpm_signing_private_key_${RPM_GPG_KEY_ID}
RPM_SIGNING_PASSPHRASE_SSM_NAME: ci.datadog-agent.rpm_signing_key_passphrase_${RPM_GPG_KEY_ID}
# docker.io authentication
DOCKER_REGISTRY_LOGIN_SSM_KEY: docker_hub_login
DOCKER_REGISTRY_PWD_SSM_KEY: docker_hub_pwd
Expand Down
3 changes: 3 additions & 0 deletions omnibus/config/projects/agent.rb
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@
priority 'extra'
if ENV.has_key?('RPM_SIGNING_PASSPHRASE') and not ENV['RPM_SIGNING_PASSPHRASE'].empty?
signing_passphrase "#{ENV['RPM_SIGNING_PASSPHRASE']}"
if ENV.has_key?('RPM_GPG_KEY_NAME') and not ENV['RPM_GPG_KEY_NAME'].empty?
gpg_key_name "#{ENV['RPM_GPG_KEY_NAME']}"
end
end
end

Expand Down
3 changes: 3 additions & 0 deletions omnibus/config/projects/dogstatsd.rb
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@
priority 'extra'
if ENV.has_key?('RPM_SIGNING_PASSPHRASE') and not ENV['RPM_SIGNING_PASSPHRASE'].empty?
signing_passphrase "#{ENV['RPM_SIGNING_PASSPHRASE']}"
if ENV.has_key?('RPM_GPG_KEY_NAME') and not ENV['RPM_GPG_KEY_NAME'].empty?
gpg_key_name "#{ENV['RPM_GPG_KEY_NAME']}"
end
end
end

Expand Down
3 changes: 3 additions & 0 deletions omnibus/config/projects/iot-agent.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@
priority 'extra'
if ENV.has_key?('RPM_SIGNING_PASSPHRASE') and not ENV['RPM_SIGNING_PASSPHRASE'].empty?
signing_passphrase "#{ENV['RPM_SIGNING_PASSPHRASE']}"
if ENV.has_key?('RPM_GPG_KEY_NAME') and not ENV['RPM_GPG_KEY_NAME'].empty?
gpg_key_name "#{ENV['RPM_GPG_KEY_NAME']}"
end
end
end

Expand Down
14 changes: 14 additions & 0 deletions releasenotes/notes/rotate-signing-keys-0b8ee4d1e6e260d9.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Each section from every release note are combined when the
# CHANGELOG.rst is rendered. So the text needs to be worded so that
# it does not depend on any information only available in another
# section. This may mean repeating some details, but each section
# must be readable independently of the other.
#
# Each section note must be formatted as reStructuredText.
---
upgrade:
- |
Package signing keys were rotated:
* DEB packages are now signed with key ``AD9589B7``, a signing subkey of key `F14F620E <https://keys.datadoghq.com/DATADOG_APT_KEY_F14F620E.public>`_
* RPM packages are now signed with key `FD4BF915 <https://keys.datadoghq.com/DATADOG_RPM_KEY_FD4BF915.public>`_

0 comments on commit 47f71b3

Please sign in to comment.