Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-972] Revert "💥 always use alternative domains for RUM (#944)" #963

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

EU doesn't have the new intake domain available yet.

Changes

This reverts commit 6fd361c.

Testing

CI


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner July 27, 2021 12:38
@BenoitZugmeyer BenoitZugmeyer changed the title Revert "💥 always use alternative domains for RUM (#944)" [RUMF-972] Revert "💥 always use alternative domains for RUM (#944)" Jul 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #963 (864b9d8) into main (4950a32) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
+ Coverage   89.07%   89.09%   +0.02%     
==========================================
  Files          83       83              
  Lines        3871     3871              
  Branches      858      858              
==========================================
+ Hits         3448     3449       +1     
+ Misses        423      422       -1     
Impacted Files Coverage Δ
packages/rum-core/src/boot/rumPublicApi.ts 97.95% <100.00%> (ø)
packages/core/src/tools/timeUtils.ts 93.93% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4950a32...864b9d8. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 66e4c27 into main Jul 27, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/revert-alternate-intake-option branch July 27, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants