✨ [RUMF-940] implement the replay sample rate option and remove resource sample rate option #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed, the "replaySampleRate" option will replace the "resourceSampleRate" option since it will re-use the same value in the session cookie. As a first step to introduce the "replaySampleRate" option, let's remove internal code related to resource sample rate. This commit intentionally keeps the "resourceSampleRate" configuration option. It will be replaced by the "replaySampleRate" in the next commit.
This option simply replaces the previous "resourceSampleRate".
BenoitZugmeyer
force-pushed
the
benoit/add-replay-sample-rate-option
branch
from
b14f0bd to
eb14cc9
Compare
Codecov Report
@@ Coverage Diff @@
## prerelease-v3 #931 +/- ##
=================================================
+ Coverage 89.01% 89.05% +0.04%
=================================================
Files 82 83 +1
Lines 3860 3884 +24
Branches 863 865 +2
=================================================
+ Hits 3436 3459 +23
- Misses 424 425 +1
Continue to review full report at Codecov.
|
amortemousque
approved these changes
Jul 12, 2021
BenoitZugmeyer
changed the title
bcaudan
reviewed
Jul 13, 2021
Comment on lines
+19
to
+23
| // Note: the "tracking type" value (stored in the session cookie) does not match the "session | ||
| // plan" value (sent in RUM events). This is expected, and was done to keep retrocompatibility | ||
| // with active sessions when upgrading the SDK. | ||
| TRACKED_REPLAY = '1', | ||
| TRACKED_LITE = '2', |
There was a problem hiding this comment.
As TRACKED_WITHOUT_RESOURCES is not strictly equivalent to TRACKED_LITE, we could also consider to perform a new draw or consider the active session as not tracked anymore.
It sounds fine to me but it worth mentioning this behavior to @hdelaby.
BenoitZugmeyer
force-pushed
the
benoit/add-replay-sample-rate-option
branch
from
c6f71cf to
7267cf0
Compare
bcaudan
approved these changes
Jul 13, 2021
Co-authored-by: Bastien Caudan <[email protected]>
amortemousque
pushed a commit
that referenced
this pull request
Jul 20, 2021
…rce sample rate option (#931) * 🔥 [RUMF-940] remove session.isTrackedWithResource support As discussed, the "replaySampleRate" option will replace the "resourceSampleRate" option since it will re-use the same value in the session cookie. As a first step to introduce the "replaySampleRate" option, let's remove internal code related to resource sample rate. This commit intentionally keeps the "resourceSampleRate" configuration option. It will be replaced by the "replaySampleRate" in the next commit. * 🚚 [RUMF-940] add the `replaySampleRate` option to the configuration This option simply replaces the previous "resourceSampleRate". * 🚚 [RUMF-940] adjust the "Tracking Type" namings to match the "Session Plan" * ✨ [RUMF-940] collect long tasks only with replay plans * ♻️ [RUMF-940] use SetupBuilder in rumRecorderPublicApi * ✨ [RUMF-940] don't start session replay recording for non-replay plans * remove unneeded TODO comment * 👌📝 add a bit of documentation on RecorderStatus * ✅ add mocking utility for Rum sessions * 👌 replace getPlan with hasReplayPlan/hasLitePlan * remove double slash in module path Co-authored-by: Bastien Caudan <[email protected]> Co-authored-by: Bastien Caudan <[email protected]>
amortemousque
pushed a commit
that referenced
this pull request
Jul 21, 2021
…rce sample rate option (#931) * 🔥 [RUMF-940] remove session.isTrackedWithResource support As discussed, the "replaySampleRate" option will replace the "resourceSampleRate" option since it will re-use the same value in the session cookie. As a first step to introduce the "replaySampleRate" option, let's remove internal code related to resource sample rate. This commit intentionally keeps the "resourceSampleRate" configuration option. It will be replaced by the "replaySampleRate" in the next commit. * 🚚 [RUMF-940] add the `replaySampleRate` option to the configuration This option simply replaces the previous "resourceSampleRate". * 🚚 [RUMF-940] adjust the "Tracking Type" namings to match the "Session Plan" * ✨ [RUMF-940] collect long tasks only with replay plans * ♻️ [RUMF-940] use SetupBuilder in rumRecorderPublicApi * ✨ [RUMF-940] don't start session replay recording for non-replay plans * remove unneeded TODO comment * 👌📝 add a bit of documentation on RecorderStatus * ✅ add mocking utility for Rum sessions * 👌 replace getPlan with hasReplayPlan/hasLitePlan * remove double slash in module path Co-authored-by: Bastien Caudan <[email protected]> Co-authored-by: Bastien Caudan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Let the customer chose which session plan to use.
Changes
We chose to use the same value as the deprecated "session without resource" to represent "sessions with lite plans" in session cookies. Because of this, replacing the deprecated
resourceSampleRateoption with the newreplaySampleRateoption in a single PR made more sense than doing it in separate PRs.resourceSampleRateoption withreplaySampleRateTesting
Unit, manual
I have gone over the contributing documentation.