Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 [RUMF-927] monitor timings with high values #884

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jun 4, 2021

Motivation

customer report with some values in weeks

Changes

add monitoring log with extra info on clock state to see if there is any inconsistencies

Testing

manual


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner June 4, 2021 16:19
@codecov-commenter
Copy link

Codecov Report

Merging #884 (45decaf) into main (7920082) will decrease coverage by 0.05%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
- Coverage   88.84%   88.78%   -0.06%     
==========================================
  Files          81       81              
  Lines        3755     3762       +7     
  Branches      833      836       +3     
==========================================
+ Hits         3336     3340       +4     
- Misses        419      422       +3     
Impacted Files Coverage Δ
...main/rumEventsCollection/resource/resourceUtils.ts 94.66% <50.00%> (-1.23%) ⬇️
...umEventsCollection/view/trackInitialViewTimings.ts 96.66% <50.00%> (-3.34%) ⬇️
packages/core/src/tools/utils.ts 90.78% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7920082...45decaf. Read the comment docs.

@bcaudan bcaudan merged commit 2d0efc9 into main Jun 7, 2021
@bcaudan bcaudan deleted the bcaudan/high-value-logs branch June 7, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants