✨ [RUMF-909] add beforeSend context #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
commented
Jun 4, 2021
BenoitZugmeyer
commented
Jun 4, 2021
BenoitZugmeyer
commented
Jun 4, 2021
BenoitZugmeyer
commented
Jun 4, 2021
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
commented
Jun 4, 2021
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
force-pushed
the
benoit/add-beforesend-context
branch
from
dc46438 to
3a5e9f1
Compare
BenoitZugmeyer
force-pushed
the
benoit/add-beforesend-context
branch
from
3a5e9f1 to
ca9e9d3
Compare
packages/rum-core/src/domain/rumEventsCollection/longTask/longTaskCollection.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackViews.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #883 +/- ##
==========================================
+ Coverage 89.09% 89.13% +0.04%
==========================================
Files 81 81
Lines 3787 3793 +6
Branches 845 848 +3
==========================================
+ Hits 3374 3381 +7
+ Misses 413 412 -1
Continue to review full report at Codecov.
|
Also, never expose PerformanceEntry objects directly for consistency.
BenoitZugmeyer
force-pushed
the
benoit/add-beforesend-context
branch
from
d9afc38 to
d3e2519
Compare
bcaudan
reviewed
Jun 8, 2021
packages/rum-core/src/domain/rumEventsCollection/error/errorCollection.spec.ts
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/trackViews.ts
Outdated
Show resolved
Hide resolved
Also, prefix fetch-related fields with 'fetch'
BenoitZugmeyer
force-pushed
the
benoit/add-beforesend-context
branch
from
2a3e6ea to
5be2e79
Compare
bcaudan
reviewed
Jun 8, 2021
bcaudan
reviewed
Jun 8, 2021
packages/rum-core/src/domain/rumEventsCollection/longTask/longTaskCollection.ts
Outdated
Show resolved
Hide resolved
This is a middle ground between having a single type to make type inference on an internal type (RawRumEvent), and having a structures union making the overall type less strict. This avoids exposing internal types, and let the user cast the domain to particular, explicit interfaces. Also, export those types publicly.
Implement `toJSON` for RumPerformanceLongTaskTiming, so it can be used even during tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that
beforeSendcan edit the event context, it would be useful to have access on a bit of information about the browser data that have been used to generate the event.Changes
For each kind of RUM event, expose a domain-related 'context' as a second argument of
beforeSend.Testing
Manual, unit
I have gone over the contributing documentation.