Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [logs] Fix IE11 console.log issue #852

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented May 18, 2021

Motivation

Invalid calling object errors reported since 2.9.0, related to #847.

Explanation: IE 11 console implementation has still some behavior differences when devtools are open or not

To reproduce:

  • open the page with devtools closed
  • open the devtools
  • create a console logger and log a message

Result: Invalid calling object exception
Expected: message loged in console

Changes

bind console object to function references

Testing

manual


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner May 18, 2021 10:00
@bcaudan bcaudan force-pushed the bcaudan/ie11-console branch from 310fd0b to 0bfa8ff Compare May 18, 2021 13:52
@bcaudan bcaudan merged commit 755a931 into main May 18, 2021
@bcaudan bcaudan deleted the bcaudan/ie11-console branch May 18, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants