⚡️ [RUMF-902] enable new mutation observer

packages/rum-recorder/src/boot/recorder.ts

@@ -27,7 +27,6 @@ export function startRecording(
 
   const { stop: stopRecording, takeFullSnapshot } = record({
     emit: addRawRecord,
-    useNewMutationObserver: configuration.isEnabled('new-mutation-observer'),
   })
 
   lifeCycle.subscribe(LifeCycleEventType.VIEW_CREATED, takeFullSnapshot)

packages/rum-recorder/src/domain/rrweb-snapshot/index.ts

@@ -1,5 +1,5 @@
-import { serializeNodeWithId, transformAttribute, snapshot } from './snapshot'
+import { serializeNodeWithId, transformAttribute, serializeDocument } from './snapshot'
 export * from './types'
 export * from './serializationUtils'
 
-export { snapshot, serializeNodeWithId, transformAttribute }
+export { serializeDocument, serializeNodeWithId, transformAttribute }

packages/rum-recorder/src/domain/rrweb-snapshot/snapshot.spec.ts

@@ -80,7 +80,6 @@ describe('serializeNodeWithId', () => {
   describe('ignores some nodes', () => {
     const defaultOptions = {
       doc: document,
-      skipChild: false,
       map: {},
     }
 

packages/rum-recorder/src/domain/rrweb-snapshot/snapshot.ts

@@ -1,6 +1,6 @@
 import { nodeShouldBeHidden } from '../privacy'
 import { PRIVACY_ATTR_NAME, PRIVACY_ATTR_VALUE_HIDDEN } from '../../constants'
-import { SerializedNode, SerializedNodeWithId, NodeType, Attributes, INode, IdNodeMap } from './types'
+import { SerializedNode, SerializedNodeWithId, NodeType, Attributes, IdNodeMap } from './types'
 import { getSerializedNodeId, hasSerializedNode, IGNORED_NODE_ID, setSerializedNode } from './serializationUtils'
 
 const tagNameRegex = /[^a-z1-6-_]/
@@ -10,11 +10,6 @@ function genId(): number {
   return nextId++
 }
 
-export function cleanupSnapshot() {
-  // allow a new recording to start numbering nodes from scratch
-  nextId = 1
-}
-
 function getValidTagName(tagName: string): string {
   const processedTagName = tagName.toLowerCase().trim()
 
@@ -358,15 +353,14 @@ function nodeShouldBeIgnored(sn: SerializedNode): boolean {
 }
 
 export function serializeNodeWithId(
-  n: Node | INode,
+  n: Node,
   options: {
     doc: Document
     map: IdNodeMap
-    skipChild: boolean
     preserveWhiteSpace?: boolean
   }
 ): SerializedNodeWithId | null {
-  const { doc, map, skipChild = false } = options
+  const { doc, map } = options
   let { preserveWhiteSpace = true } = options
   const serializedNode = serializeNode(n, {
     doc,
@@ -398,10 +392,10 @@ export function serializeNodeWithId(
   if (id === IGNORED_NODE_ID) {
     return null
   }
-  map[id] = n as INode
-  let recordChild = !skipChild
+  map[id] = true
+  let recordChild = true
   if (serializedNode.type === NodeType.Element) {
-    recordChild = recordChild && !serializedNode.shouldBeHidden
+    recordChild = !serializedNode.shouldBeHidden
     // this property was not needed in replay side
     delete serializedNode.shouldBeHidden
   }
@@ -417,7 +411,6 @@ export function serializeNodeWithId(
       const serializedChildNode = serializeNodeWithId(childN, {
         doc,
         map,
-        skipChild,
         preserveWhiteSpace,
       })
       if (serializedChildNode) {
@@ -428,14 +421,10 @@ export function serializeNodeWithId(
   return serializedNodeWithId
 }
 
-export function snapshot(n: Document): [SerializedNodeWithId | null, IdNodeMap] {
-  const idNodeMap: IdNodeMap = {}
-  return [
-    serializeNodeWithId(n, {
-      doc: n,
-      map: idNodeMap,
-      skipChild: false,
-    }),
-    idNodeMap,
-  ]
+export function serializeDocument(n: Document): SerializedNodeWithId {
+  // We are sure that Documents are never ignored, so this function never returns null
+  return serializeNodeWithId(n, {
+    doc: n,
+    map: {},
+  })!
 }

packages/rum-recorder/src/domain/rrweb-snapshot/types.ts

@@ -51,10 +51,6 @@ export type SerializedNode = DocumentNode | DocumentTypeNode | ElementNode | Tex
 
 export type SerializedNodeWithId = SerializedNode & { id: number }
 
-export interface INode extends Node {
-  __sn: SerializedNodeWithId
-}
-
 export type IdNodeMap = {
-  [key: number]: INode
+  [key: number]: true
 }