Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-889] apply correction only for positive drift #821

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 29, 2021

Motivation

Monotonic clock can be in advance compared to system clock which does not fit the identified issue.

Changes

Apply drift correction only for positive drift.

Testing

manual


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner April 29, 2021 16:30
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #821 (6d55b7d) into master (bb2e83e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
- Coverage   86.92%   86.87%   -0.05%     
==========================================
  Files          80       80              
  Lines        3869     3871       +2     
  Branches      879      880       +1     
==========================================
  Hits         3363     3363              
- Misses        506      508       +2     
Impacted Files Coverage Δ
packages/core/src/tools/timeUtils.ts 77.50% <0.00%> (-4.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2e83e...6d55b7d. Read the comment docs.

@bcaudan bcaudan force-pushed the bcaudan/fix-document-start branch 2 times, most recently from 649e8b8 to deacdab Compare April 29, 2021 17:06
@bcaudan bcaudan changed the title ⚗ [RUMF-889] monitor document start before navigation start 🐛 [RUMF-889] apply correction only for positive drift Apr 29, 2021
@bcaudan bcaudan force-pushed the bcaudan/fix-document-start branch from deacdab to 861ced8 Compare April 29, 2021 17:09
@bcaudan bcaudan merged commit cf5109a into master Apr 30, 2021
@bcaudan bcaudan deleted the bcaudan/fix-document-start branch April 30, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants