🐛 fallback to xhr when sendBeacon throws #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
approved these changes
Apr 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
==========================================
- Coverage 86.82% 86.73% -0.09%
==========================================
Files 77 77
Lines 3642 3649 +7
Branches 828 829 +1
==========================================
+ Hits 3162 3165 +3
- Misses 480 484 +4
Continue to review full report at Codecov.
|
felipeplets
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
From the spec, sendBeacon can throw TypeError.
cf #794
Changes
Fallback to xhr when sendBeacon throws
Testing
unit
I have gone over the contributing documentation.