[RUMF-867] implement stop recording #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/rum-core/src/domain/rumEventsCollection/view/trackViews.spec.ts
Show resolved
Hide resolved
| @@ -79,6 +79,9 @@ export interface RawRumViewEvent { | |||
| long_task: Count | |||
| resource: Count | |||
| } | |||
| session: { | |||
| has_replay: true | undefined | |||
There was a problem hiding this comment.
Semantically it would be better to have a boolean?
There was a problem hiding this comment.
Yes but in practice, this field should not exist for backward and other SDK compatibility. If I want to select all events that don't have replay, using @session.has_replay:false would lead to incorrect results since not all SDKs implement this flag. Using [email protected]_replay:true is the way to go.
Using this weird typing forces us to ensure has_replay is never false.
bcaudan
reviewed
Mar 29, 2021
Having multiple loose variables to reflect a state does not scale. Instead of adding a new `isStopped` variable, make things more explicit by using a finite number of states, acting like a single source of truth for the whole segment collection. This helps to understand the various state transitions.
bcaudan
reviewed
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement a method to stop session replay recording
Changes
true.Testing
Unit, manual
I have gone over the contributing documentation.