Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Doc: remove resourceSampleRate #747

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 24, 2021

Motivation

No reason to promote this configuration parameter since it is not aligned with billing.
It only confuses customers and generate support questions.

Changes

Remove resourceSampleRate from doc + add deprecated note in configuration

Testing

NA


I have gone over the contributing documentation.

No reason to promote this configuration parameter since it is not aligned with billing.
It only confuses customers and generate support questions.
@bcaudan bcaudan requested review from a team as code owners February 24, 2021 14:48
Copy link
Contributor

@jtappa jtappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 from docs

@bcaudan bcaudan merged commit 41266eb into master Feb 25, 2021
@bcaudan bcaudan deleted the bcaudan/remove-doc-rsr branch February 25, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants