[RUM] Catch errors thrown by user callbacks #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,11 @@ | |||
| export function catchErrors<Args extends any[], R>(fn: (...args: Args) => R, errorMsg: string) { | |||
There was a problem hiding this comment.
I would rename it to catchUserErrors to make it a bit clearer
bcaudan
reviewed
Feb 24, 2021
packages/rum-core/src/domain/rumEventsCollection/view/trackViews.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Benoît <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
- Coverage 82.58% 82.39% -0.19%
==========================================
Files 74 75 +1
Lines 3807 3806 -1
Branches 907 908 +1
==========================================
- Hits 3144 3136 -8
- Misses 663 670 +7
Continue to review full report at Codecov.
|
bcaudan
reviewed
Feb 24, 2021
Co-authored-by: Bastien Caudan <[email protected]>
This is needed to make the test able to pass its own Lifecycle object and test that onNewLocation catches user errors after being wrapped. The stopViewCollection is needed because startViewCollection attaches a listener to history changes, and if not removed, it will be executed on all following tests and generates unwanted console.errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Catch errors thrown by user-provided callbacks and log them using
console.error.Changes
catchErrorsbeforeSend,onNewLocationand callbacks given toonReadybefore the SDK initialization.Testing
I have gone over the contributing documentation.