Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-854] Enable beforeSend to dismiss events #743

Merged
merged 10 commits into from
Feb 23, 2021
Merged

Conversation

webNeat
Copy link
Contributor

@webNeat webNeat commented Feb 22, 2021

Motivation

Allow customers to dismiss RUM events.

Changes

  • Use RUM_EVENT_COLLECTED event to update event counts.
  • Dismiss the event if beforeSend returned false and it's not a view event.
  • Show a warning if beforeSend returned false for a view event.

Testing

  • unit tests
  • manual

I have gone over the contributing documentation.

@webNeat webNeat requested a review from a team as a code owner February 22, 2021 18:09
@codecov-io
Copy link

Codecov Report

Merging #743 (0fdce7e) into master (44cfa26) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
+ Coverage   82.41%   82.58%   +0.17%     
==========================================
  Files          74       74              
  Lines        3798     3807       +9     
  Branches      903      907       +4     
==========================================
+ Hits         3130     3144      +14     
+ Misses        668      663       -5     
Impacted Files Coverage Δ
packages/core/src/domain/configuration.ts 76.00% <ø> (ø)
packages/rum-core/src/boot/rumPublicApi.ts 94.11% <ø> (ø)
packages/core/src/tools/limitModification.ts 96.77% <100.00%> (ø)
packages/logs/src/boot/logs.ts 72.34% <100.00%> (+1.22%) ⬆️
packages/rum-core/src/domain/assembly.ts 100.00% <100.00%> (ø)
packages/rum-core/src/domain/trackEventCounts.ts 100.00% <100.00%> (ø)
...ckages/core/src/domain/automaticErrorCollection.ts 100.00% <0.00%> (+1.58%) ⬆️
packages/rum-core/src/transport/batch.ts 77.14% <0.00%> (+11.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44cfa26...0fdce7e. Read the comment docs.

Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants