-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-854] Enable beforeSend to dismiss events #743
Conversation
Co-authored-by: Benoît <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 82.41% 82.58% +0.17%
==========================================
Files 74 74
Lines 3798 3807 +9
Branches 903 907 +4
==========================================
+ Hits 3130 3144 +14
+ Misses 668 663 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Motivation
Allow customers to dismiss RUM events.
Changes
RUM_EVENT_COLLECTED
event to update event counts.beforeSend
returnedfalse
and it's not a view event.beforeSend
returnedfalse
for a view event.Testing
I have gone over the contributing documentation.