replay: set data-dd-privacy attribute on snapshot node if hidden #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NIT: I kind of think a unit test would be better for this change, but the e2e test may be enough |
BenoitZugmeyer
approved these changes
Feb 9, 2021
As a node can be hidden from a data attribute rather than a class, only adding the class to the snapshot node attributes means we can't properly style the node when rebuilding it. This commit ensures the data-dd-privacy=hidden attribute is always set, even if the node was hidden using the class. Additionally, we set the ID as a/ it helps with testing, b/ we can assume it doesn't contain PII and c/ it may be used when rebuilding (CSS rules could be selecting by ID).
vlad-mh
force-pushed
the
vlad/rum-replay-privacy-set-attributes-on-snapshot-node
branch
from
dc1ff2d to
bf3f7cd
Compare
webNeat
pushed a commit
that referenced
this pull request
Feb 15, 2021
As a node can be hidden from a data attribute rather than a class, only adding the class to the snapshot node attributes means we can't properly style the node when rebuilding it. This commit ensures the data-dd-privacy=hidden attribute is always set, even if the node was hidden using the class. Additionally, we set the ID as a/ it helps with testing, b/ we can assume it doesn't contain PII and c/ it may be used when rebuilding (CSS rules could be selecting by ID).
bcaudan
deleted the
vlad/rum-replay-privacy-set-attributes-on-snapshot-node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up on #715
As a node can be hidden from a data attribute rather than a class,
only adding the class to the snapshot node attributes means we can't
properly style the node when rebuilding it.
This PR ensures the
data-dd-privacy=hiddenattribute is alwaysset, even if the node was hidden using the class.
Additionally, we set the ID as a/ it helps with testing, b/ we can
assume it doesn't contain PII and c/ it may be used when
rebuilding (CSS rules could be selecting by ID).