Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 recorder: remove forEach polyfills #719

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 4, 2021

Motivation

Avoid to touch shared API if it is not needed

Changes

Replace forEach polyfills by a forEach utility function

Testing

ci


I have gone over the contributing documentation.

@bcaudan bcaudan marked this pull request as ready for review February 4, 2021 15:31
@bcaudan bcaudan requested a review from a team as a code owner February 4, 2021 15:31
@codecov-io
Copy link

Codecov Report

Merging #719 (e0d3b9a) into master (e6d6265) will increase coverage by 0.16%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   80.50%   80.66%   +0.16%     
==========================================
  Files          71       71              
  Lines        3739     3729      -10     
  Branches      887      883       -4     
==========================================
- Hits         3010     3008       -2     
+ Misses        729      721       -8     
Impacted Files Coverage Δ
...rum-recorder/src/domain/rrweb-snapshot/snapshot.ts 58.24% <0.00%> (+1.15%) ⬆️
packages/rum-recorder/src/domain/rrweb/observer.ts 55.02% <0.00%> (ø)
packages/rum-recorder/src/domain/rrweb/record.ts 64.15% <ø> (-0.34%) ⬇️
packages/rum-recorder/src/domain/rrweb/utils.ts 45.54% <50.00%> (+0.35%) ⬆️
packages/rum-recorder/src/domain/rrweb/mutation.ts 56.50% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d6265...e0d3b9a. Read the comment docs.

@bcaudan bcaudan merged commit 26e63c7 into master Feb 4, 2021
@bcaudan bcaudan deleted the bcaudan/remove-polyfill branch February 4, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants