🐛[RUMF-809] URL encode tags in intake requests #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
force-pushed
the
bcaudan/url-encode-tags
branch
from
93e9a75 to
a933dc2
Compare
BenoitZugmeyer
approved these changes
Jan 21, 2021
kcaffrey
pushed a commit
to WonderInventions/browser-sdk
that referenced
this pull request
Jan 29, 2021
* 🐛[RUMF-809] url encode tags in intake requests * 👌 add extra test on tags encoding
kcaffrey
added a commit
to WonderInventions/browser-sdk
that referenced
this pull request
Jan 29, 2021
This reverts commit 8b051ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure that tags value are properly interpreted on backend side.
Note: most of the special characters are converted to underscore anyway, cf tags doc.
Changes
URL encode value of
tagsquery param in intake requestsTesting
Unit + manual test
I have gone over the contributing documentation.