🐛 fix replica application overwrite #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
- Coverage 87.85% 87.75% -0.11%
==========================================
Files 56 56
Lines 2561 2564 +3
Branches 551 553 +2
==========================================
Hits 2250 2250
- Misses 311 314 +3
Continue to review full report at Codecov.
|
BenoitZugmeyer
approved these changes
Nov 23, 2020
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replica application overwrite does not work in v2
Changes
Use the right format
Testing
manual test
I have gone over the contributing documentation.