Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Recommend to use matching versions #615

Merged
merged 6 commits into from
Nov 16, 2020
Merged

📝 Recommend to use matching versions #615

merged 6 commits into from
Nov 16, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Nov 13, 2020

Motivation

Following #611, improve documentation.

Changes

  • add warning close to xhr shared data structure
  • add note on npm setup to recommend using matching versions

I have gone over the contributing documentation.

@bcaudan bcaudan requested review from a team as code owners November 13, 2020 10:41
Copy link
Contributor

@sarina-dd sarina-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small edits

packages/logs/README.md Outdated Show resolved Hide resolved
packages/logs/README.md Outdated Show resolved Hide resolved
packages/rum/README.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #615 (a79a53b) into master (b4b57c4) will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   88.81%   89.13%   +0.31%     
==========================================
  Files          54       54              
  Lines        2503     2503              
  Branches      541      541              
==========================================
+ Hits         2223     2231       +8     
+ Misses        280      272       -8     
Impacted Files Coverage Δ
packages/core/src/browser/xhrProxy.ts 100.00% <ø> (ø)
...ckages/core/src/domain/automaticErrorCollection.ts 100.00% <0.00%> (+1.58%) ⬆️
packages/rum/src/browser/performanceCollection.ts 65.71% <0.00%> (+2.85%) ⬆️
packages/rum/src/transport/batch.ts 80.48% <0.00%> (+12.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b57c4...a79a53b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants