[RUMF-729] validate rum events in e2e #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
force-pushed
the
bcaudan/e2e-v2
branch
from
1616904 to
c08ce7a
Compare
bcaudan
force-pushed
the
bcaudan/e2e-v2
branch
from
c08ce7a to
d457cdf
Compare
BenoitZugmeyer
approved these changes
Nov 2, 2020
| @@ -20,7 +20,7 @@ | |||
| "no-implicit-dependencies": [ | |||
| true, | |||
| "dev", | |||
| ["@datadog/browser-logs", "@datadog/browser-rum", "@datadog/browser-core"] | |||
| ["@datadog/browser-logs", "@datadog/browser-rum", "@datadog/browser-core", "ajv"] | |||
There was a problem hiding this comment.
FMU, ajv is installed because it is listed in the rum workspace dependencies, and hoisted in the root node_modules folder. Why not listing ajv as a root package.json dependency? We could either keep or remove it from rum dependencies.
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
==========================================
+ Coverage 88.14% 88.18% +0.04%
==========================================
Files 52 52
Lines 2472 2472
Branches 526 526
==========================================
+ Hits 2179 2180 +1
+ Misses 293 292 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With migration of different event types to v2 format, validate events generated during e2e tests.
Changes
Testing
automated tests
I have gone over the contributing documentation.