Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUMF-451] compute session type for each event #375

Merged
merged 4 commits into from
Apr 24, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 23, 2020

synthetics instrumentation is delayed on new page creation
avoid to mess the session type of all the events of the page

and ♻️session type naming collision

bcaudan added 2 commits April 23, 2020 17:03
- cookie session type -> tracking type
- cookie session type key -> product key
synthetics instrumentation is delayed on new page creation
avoid to mess the session type of all the events of the page
@bcaudan bcaudan requested a review from a team as a code owner April 23, 2020 15:18
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcaudan bcaudan merged commit 674ed46 into master Apr 24, 2020
@bcaudan bcaudan deleted the bcaudan/fix-session-type branch April 24, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants