Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUM] fix view update after its end #373

Merged
merged 5 commits into from
Apr 24, 2020

Conversation

BenoitZugmeyer
Copy link
Member

With the last release (v1.11.0), we have seen a lot of "duplicated" views, meaning view events with the same id but a different date. This is likely caused by the throttled updateView function, sending a view update after the view ends when a timing or a event count have changed right before the view end.

This fixes the issue by ensuring that the view sending an update is still the current view.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner April 23, 2020 08:55
@codecov-io
Copy link

Codecov Report

Merging #373 into master will decrease coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   87.13%   86.83%   -0.31%     
==========================================
  Files          30       30              
  Lines        1695     1701       +6     
  Branches      344      345       +1     
==========================================
  Hits         1477     1477              
- Misses        218      224       +6     
Impacted Files Coverage Δ
packages/rum/src/viewCollection.ts 94.73% <100.00%> (+0.61%) ⬆️
packages/rum/src/rum.ts 84.04% <0.00%> (-6.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99dcd70...ba2af7c. Read the comment docs.

@bcaudan bcaudan force-pushed the benoit/fix-view-update-after-ended branch from 8ff94b4 to 4b0f454 Compare April 23, 2020 16:28
@BenoitZugmeyer
Copy link
Member Author

LGTM! thanks. (PR authors can't approve their PR, so let's say it's ✅ )

@bcaudan bcaudan merged commit b2075aa into master Apr 24, 2020
@bcaudan bcaudan deleted the benoit/fix-view-update-after-ended branch April 24, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants