Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-430] new session cookie format #337

Merged
merged 4 commits into from
Apr 6, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 3, 2020

  • new _dd_s cookie to store all session info
  • maintain _dd, _dd_l and _dd_r cookies to allow rollback without compatibility issue
  • add migration to not break active sessions during the new format deployment

bcaudan added 3 commits April 3, 2020 15:19
- new _dd_s cookie to store all session info
- maintain _dd, _dd_l and _dd_r cookies to allow rollback without compatibility issue
ensure to not break active sessions during the new format deployment
@bcaudan bcaudan requested a review from a team as a code owner April 3, 2020 15:34
@codecov-io
Copy link

Codecov Report

Merging #337 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   85.53%   85.87%   +0.33%     
==========================================
  Files          26       26              
  Lines        1466     1487      +21     
  Branches      312      312              
==========================================
+ Hits         1254     1277      +23     
+ Misses        212      210       -2     
Impacted Files Coverage Δ
packages/core/src/oldCookiesMigration.ts 100.00% <100.00%> (ø)
packages/core/src/sessionManagement.ts 100.00% <100.00%> (ø)
packages/core/src/utils.ts 96.42% <100.00%> (+0.06%) ⬆️
packages/logs/src/loggerSession.ts 100.00% <100.00%> (+4.54%) ⬆️
packages/rum/src/rumSession.ts 100.00% <100.00%> (ø)
packages/logs/src/logger.ts 95.77% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d718e92...99d61a3. Read the comment docs.

Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcaudan bcaudan merged commit 8d67112 into master Apr 6, 2020
@bcaudan bcaudan deleted the bcaudan/new-cookie-format-v2 branch April 6, 2020 11:55
bcaudan added a commit that referenced this pull request Apr 6, 2020
bcaudan added a commit that referenced this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants