🐛fix feature check #320
Merged
🐛fix feature check #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 81.92% 81.97% +0.04%
==========================================
Files 26 26
Lines 1505 1509 +4
Branches 316 318 +2
==========================================
+ Hits 1233 1237 +4
Misses 272 272
Continue to review full report at Codecov.
|
bcaudan
force-pushed
the
bcaudan/fix-includes
branch
from
13a599b to
8f5329b
Compare
- array.include not supported on IE - ensure enableExperimentalFeatures is an array to avoid `Object doesn't support property or method 'includes'`
bcaudan
force-pushed
the
bcaudan/fix-includes
branch
from
8f5329b to
c1c31b2
Compare
packages/core/src/configuration.ts
Outdated
Comment on lines
81
to
82
| Array.isArray(configuration.enableExperimentalFeatures) && | ||
| includes(configuration.enableExperimentalFeatures, feature) |
There was a problem hiding this comment.
It could be cleaner to not expose configuration.enableExperimentalFeatures and use userConfiguration directly here
Suggested change
| Array.isArray(configuration.enableExperimentalFeatures) && | |
| includes(configuration.enableExperimentalFeatures, feature) | |
| Array.isArray(userConfiguration.enableExperimentalFeatures) && | |
| includes(userConfiguration.enableExperimentalFeatures, feature) |
BenoitZugmeyer
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object doesn't support property or method 'includes'