Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷‍♀️ [RUM 6237] Add e2e test for view context API init #3025

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Sep 20, 2024

Motivation

We want to have e2e tests to ensure the new APIs loaded and will not break the page.

Changes

Add view context api check in init e2e test file.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@cy-moi cy-moi force-pushed the congyao/RUM-6237-add-e2e-view-context-tests branch from ad14b55 to 83f9694 Compare September 20, 2024 09:24
Copy link

cit-pr-commenter bot commented Sep 20, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.83 KiB 161.83 KiB 0 B 0.00%
Logs 56.03 KiB 56.03 KiB 0 B 0.00%
Rum Slim 110.40 KiB 110.40 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.034 0.046 0.012
addtiming 0.001 0.001 0.000
adderror 0.032 0.033 0.000
startstopsessionreplayrecording 0.868 0.852 -0.016
startview 1.006 1.038 0.032
logmessage 0.019 0.021 0.002
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 9.39 KiB 7.33 KiB -2114 B
addaction 39.10 KiB 39.54 KiB 445 B
addtiming 7.31 KiB 6.50 KiB -832 B
adderror 44.63 KiB 43.97 KiB -673 B
startstopsessionreplayrecording 5.83 KiB 4.88 KiB -974 B
startview 356.31 KiB 363.02 KiB 6.72 KiB
logmessage 40.29 KiB 41.41 KiB 1.12 KiB

🔗 RealWorld

@cy-moi cy-moi marked this pull request as ready for review September 20, 2024 10:22
@cy-moi cy-moi requested a review from a team as a code owner September 20, 2024 10:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (5e00489) to head (75786ac).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3025   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files         275      275           
  Lines        7639     7639           
  Branches     1716     1716           
=======================================
  Hits         7134     7134           
  Misses        505      505           
Flag Coverage Δ
93.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cy-moi cy-moi force-pushed the congyao/RUM-6237-add-e2e-view-context-tests branch from e246d44 to 75786ac Compare September 23, 2024 12:29
@cy-moi cy-moi merged commit 8baa800 into main Sep 24, 2024
19 checks passed
@cy-moi cy-moi deleted the congyao/RUM-6237-add-e2e-view-context-tests branch September 24, 2024 08:11
@cy-moi cy-moi changed the title [RUM 6237] Add e2e test for view context API init 👷‍♀️ [RUM 6237] Add e2e test for view context API init Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants