Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 RUM-6203: Expose experimental features in init method #3006

Merged

Conversation

N-Boutaib
Copy link
Contributor

Motivation

Experimental Features are added to RumPublicApi when RUM is started. This could be improved by exposing them right after the initialisation of the SDK

Changes

Move updateViewName exposure to init method

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@N-Boutaib N-Boutaib force-pushed the najib.boutaib/RUM-6203-expose-updateViewName-after-init branch from 16865fc to be80257 Compare September 17, 2024 13:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (f398a81) to head (be80257).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3006   +/-   ##
=======================================
  Coverage   93.55%   93.56%           
=======================================
  Files         273      273           
  Lines        7624     7625    +1     
  Branches     1716     1716           
=======================================
+ Hits         7133     7134    +1     
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@N-Boutaib N-Boutaib marked this pull request as ready for review September 17, 2024 13:22
@N-Boutaib N-Boutaib requested a review from a team as a code owner September 17, 2024 13:22
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.87 KiB 161.86 KiB -7 B -0.00%
Logs 56.03 KiB 56.03 KiB 0 B 0.00%
Rum Slim 110.48 KiB 110.47 KiB -7 B -0.01%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 -0.001
addaction 0.036 0.039 0.002
addtiming 0.001 0.001 -0.000
adderror 0.034 0.032 -0.002
startstopsessionreplayrecording 1.101 0.839 -0.262
startview 1.062 1.040 -0.021
logmessage 0.027 0.018 -0.009
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.47 KiB 7.94 KiB 485 B
addaction 39.29 KiB 38.87 KiB -431 B
addtiming 6.55 KiB 6.73 KiB 192 B
adderror 44.68 KiB 43.76 KiB -940 B
startstopsessionreplayrecording 4.47 KiB 3.99 KiB -488 B
startview 358.49 KiB 363.92 KiB 5.43 KiB
logmessage 41.08 KiB 41.01 KiB -74 B

🔗 RealWorld

@N-Boutaib N-Boutaib merged commit 482a025 into main Sep 17, 2024
19 checks passed
@N-Boutaib N-Boutaib deleted the najib.boutaib/RUM-6203-expose-updateViewName-after-init branch September 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants