Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 allow job 'test-performance' to fail #2980

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

This job randomly fail for various reason. While it is not required to merge PRs at the GitHub level, it still blocks the gitlab pipeline, so in practice it is required.

Because we only use this job to notify performance benchmark changes on PRs, it is acceptable to bypass it sometimes. We'll need to figure out how we can make this more stable in the future.

Changes

Allow test-performance to fail at gitlab level.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

This job randomly fail for various reason. While it is not required to
merge PRs at the GitHub level, it still blocks the gitlab pipeline, so
in practice it is required.

Because we only use this job to notify performance benchmark changes on
PRs, it is acceptable to bypass it sometimes. We'll need to figure out
how we can make this more stable in the future.
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 9, 2024 14:27
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.30 KiB 161.30 KiB 0 B 0.00%
Logs 56.12 KiB 56.12 KiB 0 B 0.00%
Rum Slim 109.91 KiB 109.91 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.003 0.001 -0.002
addaction 0.063 0.036 -0.026
addtiming 0.001 0.001 -0.000
adderror 0.055 0.031 -0.023
startstopsessionreplayrecording 1.588 0.872 -0.716
startview 1.567 0.921 -0.645
logmessage 0.034 0.019 -0.015
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.84 KiB 8.30 KiB 464 B
addaction 39.55 KiB 40.57 KiB 1.01 KiB
addtiming 7.07 KiB 7.80 KiB 752 B
adderror 45.62 KiB 46.46 KiB 854 B
startstopsessionreplayrecording 5.85 KiB 4.49 KiB -1389 B
startview 342.41 KiB 348.49 KiB 6.08 KiB
logmessage 40.92 KiB 42.41 KiB 1.49 KiB

🔗 RealWorld

@BenoitZugmeyer BenoitZugmeyer merged commit 1202329 into main Sep 10, 2024
19 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/allow-test-performance-to-fail branch September 10, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants