👷 allow job 'test-performance' to fail #2980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This job randomly fail for various reason. While it is not required to merge PRs at the GitHub level, it still blocks the gitlab pipeline, so in practice it is required.
Because we only use this job to notify performance benchmark changes on PRs, it is acceptable to bypass it sometimes. We'll need to figure out how we can make this more stable in the future.
Changes
Allow
test-performance
to fail at gitlab level.Testing
I have gone over the contributing documentation.