Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 don't print log messages twice in unit tests #2959

Merged
merged 1 commit into from
Aug 30, 2024
Merged

👷 don't print log messages twice in unit tests #2959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions test/unit/karmaSkippedFailedReporterPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
function KarmaSkippedFailedReporter(baseReporterDecorator, logger) {
function KarmaSkippedFailedReporter(logger) {
var log = logger.create('karma-skipped-failed')

baseReporterDecorator(this)

this.specSkipped = this.specFailure = (browser, result) => {
this.onSpecComplete = (browser, result) => {
if (result.skipped && !result.success) {
log.warn('Failing skipped test:')
log.warn(browser.name)
Expand All @@ -13,7 +11,7 @@ function KarmaSkippedFailedReporter(baseReporterDecorator, logger) {
}
}

KarmaSkippedFailedReporter.$inject = ['baseReporterDecorator', 'logger']
KarmaSkippedFailedReporter.$inject = ['logger']

module.exports = {
'reporter:karma-skipped-failed': ['type', KarmaSkippedFailedReporter],
Expand Down