Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[RUM-5590] Add telemetry for INP null target (#2895)" #2955

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Aug 29, 2024

This reverts commit 68d89a1.

Motivation

Testing of INP Null target has finished. We do not need to include this in the release.

Changes

revert INP null target telemetry

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.46%. Comparing base (a164897) to head (85ebc98).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2955      +/-   ##
==========================================
+ Coverage   93.42%   93.46%   +0.03%     
==========================================
  Files         271      271              
  Lines        7637     7630       -7     
  Branches     1704     1699       -5     
==========================================
- Hits         7135     7131       -4     
+ Misses        502      499       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.86 KiB 160.70 KiB -172 B -0.10%
Logs 55.98 KiB 55.98 KiB 0 B 0.00%
Rum Slim 109.47 KiB 109.31 KiB -172 B -0.15%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.001 0.000
addaction 0.032 0.032 0.000
addtiming 0.001 0.001 0.000
adderror 0.033 0.032 -0.001
startstopsessionreplayrecording 0.832 0.788 -0.044
startview 1.017 0.913 -0.104
logmessage 0.028 0.019 -0.009
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 8.46 KiB 8.76 KiB 307 B
addaction 39.98 KiB 40.17 KiB 196 B
addtiming 7.73 KiB 6.36 KiB -1408 B
adderror 45.16 KiB 44.12 KiB -1063 B
startstopsessionreplayrecording 5.13 KiB 4.41 KiB -741 B
startview 317.67 KiB 320.46 KiB 2.79 KiB
logmessage 40.11 KiB 39.56 KiB -562 B

🔗 RealWorld

@cy-moi cy-moi marked this pull request as ready for review August 29, 2024 11:18
@cy-moi cy-moi requested a review from a team as a code owner August 29, 2024 11:18
@cy-moi cy-moi merged commit 95b4516 into main Aug 29, 2024
20 checks passed
@cy-moi cy-moi deleted the congyao/revert-inp-telemetry branch August 29, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants