-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUM-5705] Collect Long Animation Frames #2924
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
==========================================
- Coverage 93.54% 93.47% -0.08%
==========================================
Files 270 271 +1
Lines 7594 7616 +22
Branches 1692 1696 +4
==========================================
+ Hits 7104 7119 +15
- Misses 490 497 +7 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
entry_type: RumLongTaskEntryType.LONG_ANIMATION_FRAME, | ||
duration: toServerDuration(entry.duration), | ||
blocking_duration: toServerDuration(entry.blockingDuration), | ||
first_ui_event_timestamp: relativeToClocks(entry.firstUIEventTimestamp).relative, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despites the name suggest, it's a relative time similarly to renderStart
14830e9
to
2dc41b4
Compare
50283e4
to
aa095bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to update LongTask
event type in rum-event-format
first 🤔 ?
2c396fc
to
afe5c7e
Compare
@thomas-lebeau @nulrich hi, I am looking for this feature. PerformanceLongAnimationFrameTiming or PerformanceScriptTiming is what shows more information Currently I see "Long tasks" duration in Datadog RUM Explorer (app.datadoghq.com/rum/sessions) , but no more information , such as script source, function, etc, which is not helpful for debugging. |
Hi @blackswanny, Thanks for your interest, unfortunately this is not available yet as we're still working on polishing the UI experience. |
Motivation
Collect Long animation frame events instead of long task.
Changes
Testing
I have gone over the contributing documentation.