Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-5705] Collect Long Animation Frames #2924

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Aug 6, 2024

Motivation

Collect Long animation frame events instead of long task.

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.47%. Comparing base (309c842) to head (afe5c7e).
Report is 3 commits behind head on main.

Files Patch % Lines
packages/rum-core/src/boot/startRum.ts 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2924      +/-   ##
==========================================
- Coverage   93.54%   93.47%   -0.08%     
==========================================
  Files         270      271       +1     
  Lines        7594     7616      +22     
  Branches     1692     1696       +4     
==========================================
+ Hits         7104     7119      +15     
- Misses        490      497       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Aug 6, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 158.91 KiB 160.16 KiB 1.24 KiB +0.78%
Logs 55.93 KiB 55.98 KiB 46 B +0.08%
Rum Slim 107.52 KiB 108.76 KiB 1.24 KiB +1.16%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.007 0.005
addaction 0.036 0.199 0.163
addtiming 0.001 0.003 0.003
adderror 0.036 0.303 0.268
startstopsessionreplayrecording 0.920 6.973 6.053
startview 1.163 11.540 10.378
logmessage 0.023 0.135 0.112
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 18.14 KiB 18.50 KiB 370 B
addaction 68.40 KiB 69.57 KiB 1.17 KiB
addtiming 18.85 KiB 14.69 KiB -4255 B
adderror 85.85 KiB 84.90 KiB -964 B
startstopsessionreplayrecording 12.50 KiB 11.87 KiB -636 B
startview 346.80 KiB 349.59 KiB 2.79 KiB
logmessage 68.40 KiB 67.65 KiB -765 B

🔗 RealWorld

entry_type: RumLongTaskEntryType.LONG_ANIMATION_FRAME,
duration: toServerDuration(entry.duration),
blocking_duration: toServerDuration(entry.blockingDuration),
first_ui_event_timestamp: relativeToClocks(entry.firstUIEventTimestamp).relative,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despites the name suggest, it's a relative time similarly to renderStart

@thomas-lebeau thomas-lebeau marked this pull request as ready for review August 8, 2024 12:19
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner August 8, 2024 12:19
Copy link
Contributor

@N-Boutaib N-Boutaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to update LongTask event type in rum-event-format first 🤔 ?

@N-Boutaib N-Boutaib requested a review from a team August 9, 2024 08:03
@thomas-lebeau thomas-lebeau merged commit c0de7ea into main Aug 13, 2024
20 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/loaf branch August 13, 2024 06:32
@blackswanny
Copy link

@thomas-lebeau @nulrich hi, I am looking for this feature. PerformanceLongAnimationFrameTiming or PerformanceScriptTiming is what shows more information

Currently I see "Long tasks" duration in Datadog RUM Explorer (app.datadoghq.com/rum/sessions) , but no more information , such as script source, function, etc, which is not helpful for debugging.
We use v5.26.0 npm for rum package, but I still don't see new facets in RUM Explorer. Do you know how to make it work?

@thomas-lebeau
Copy link
Collaborator Author

Hi @blackswanny, Thanks for your interest, unfortunately this is not available yet as we're still working on polishing the UI experience.
I'll let you know when this is available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants